webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h - Issue 2377303002: Revert of Fix race / crash in OnNetworkRouteChanged().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h

Issue 2377303002: Revert of Fix race / crash in OnNetworkRouteChanged(). (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc ('k') | webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h

diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h

index 387fa67f0d916a86c396436e9c0b6d561498f166..c91c580272fc9dc79bef3bb2b3ba18740375dbb5 100644

--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h

+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h

@@ -19,7 +19,6 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "webrtc/base/constructormagic.h"

-#include "webrtc/modules/congestion_controller/delay_based_bwe.h"

#include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"

#include "webrtc/system_wrappers/include/clock.h"

@@ -161,8 +160,8 @@

static const uint32_t kDefaultSsrc;

SimulatedClock clock_; // Time at the receiver.

- test::TestBitrateObserver bitrate_observer_;

- DelayBasedBwe bitrate_estimator_;

+ std::unique_ptr<test::TestBitrateObserver> bitrate_observer_;

+ std::unique_ptr<RemoteBitrateEstimator> bitrate_estimator_;

std::unique_ptr<test::StreamGenerator> stream_generator_;

int64_t arrival_time_offset_ms_;