Fix race / crash in OnNetworkRouteChanged().

Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
Committed: https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024
Cr-Commit-Position: refs/heads/master@{#14430}

[stefan-webrtc, 2016-09-27 10:58:54]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[stefan-webrtc, 2016-09-27 10:58:55]

https://codereview.webrtc.org/2366333003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/delay_based_bwe.cc (left):

https://codereview.webrtc.org/2366333003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/delay_based_bwe.cc:78: rtc::CritScope
lock(&crit_);
Mostly it's the lock that has been removed here, causing indentation changes.

https://codereview.webrtc.org/2366333003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/delay_based_bwe.cc (right):

https://codereview.webrtc.org/2366333003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/delay_based_bwe.cc:130: result.probe =
true;
This was slightly changed since before we called a callback here.

https://codereview.webrtc.org/2366333003/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream_tests.cc (right):

https://codereview.webrtc.org/2366333003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream_tests.cc:1174: }
Changes to enable send-side BWE for this test. This triggered the crash I'm
fixing.

[stefan-webrtc, 2016-09-27 11:21:32]

Clean up

[stefan-webrtc, 2016-09-27 11:26:30]

Remove moved files from gypi.

[stefan-webrtc, 2016-09-27 11:27:48]

Rebase.

[stefan-webrtc, 2016-09-27 11:28:10]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 11:28:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2016-09-27 11:38:52]

Description was changed from

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

BUG=webrtc:6427
==========

to

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

BUG=webrtc:6427, webrtc:6422
==========

[stefan-webrtc, 2016-09-27 11:43:30]

Description was changed from

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

BUG=webrtc:6427, webrtc:6422
==========

to

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

[commit-bot: I haz the power, 2016-09-27 12:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 12:35:29]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/18669)

[stefan-webrtc, 2016-09-28 13:44:16]

.

[stefan-webrtc, 2016-09-28 13:44:28]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 13:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-28 14:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:27:50]

Dry run: This issue passed the CQ dry run.

[terelius, 2016-09-29 09:32:44]

Nice refactoring!

LGTM, with one question below:

https://codereview.webrtc.org/2366333003/diff/80001/webrtc/tools/event_log_vi...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2366333003/diff/80001/webrtc/tools/event_log_vi...
webrtc/tools/event_log_visualizer/analyzer.cc:1058: // BitrateController.
Is there an ETA for this?

[stefan-webrtc, 2016-09-29 09:35:02]

https://codereview.webrtc.org/2366333003/diff/80001/webrtc/tools/event_log_vi...
File webrtc/tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/2366333003/diff/80001/webrtc/tools/event_log_vi...
webrtc/tools/event_log_visualizer/analyzer.cc:1058: // BitrateController.
On 2016/09/29 09:32:44, terelius wrote:
> Is there an ETA for this?

Yes, I hope that it will be done in Q4. It's not a big change really, but it
affects the CongestionController interface, so I prefer that we do it as part of
doing the interface changes to that class.

[stefan-webrtc, 2016-09-29 09:35:14]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-09-29 09:35:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 09:44:34]

Description was changed from

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

to

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

[commit-bot: I haz the power, 2016-09-29 09:44:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-29 09:44:44]

Description was changed from

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422
==========

to

==========
Fix race / crash in OnNetworkRouteChanged().

To achieve this some refactoring was done to make it possible to synchronize
access to the DelayBasedBwe in TransportFeedbackAdapter:
- The callback was removed from DelayBasedBwe, it now instead returns its
  result.
- TransportFeedbackAdapter was moved to modules/congestion_controller to avoid
  unnecessary dependencies.

Reenables previously disabled flaky test. Can no longer reproduce flakiness with
gtest-parallel and asan/tsan builds.

BUG=webrtc:6427, webrtc:6422

Committed: https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024
Cr-Commit-Position: refs/heads/master@{#14430}
==========

[commit-bot: I haz the power, 2016-09-29 09:44:46]

Patchset 5 (id:??) landed as
https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024
Cr-Commit-Position: refs/heads/master@{#14430}

[stefan-webrtc, 2016-09-29 11:19:25]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2377303002/ by stefan@webrtc.org.

The reason for reverting is: Caused issues with webrtc_perf_tests on build
bots..