Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1923613003: Revert of Delete video_render module. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete video_render module. (patchset #12 id:220001 of https://codereview.webrtc.org/1912143002/ ) Reason for revert: This breaks every buildbot in chromium.webrtc.fyi and I don't see any roll in progress to address this (and I don't see how that would be possible either). Usage in Chrome: https://code.google.com/p/chromium/codesearch#search/&q=modules.gyp%3Avideo_render&sq=package:chromium&type=cs Example failures: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/5420 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/4526 I think it's fine to delete our video_render_module_internal_impl target and those files, but video_render target needs to remain. Original issue's description: > Delete video_render module. > > BUG=webrtc:5817 > > Committed: https://crrev.com/97cfd1ec05d07ef233356e57f7aa4b028b74ffba > Cr-Commit-Position: refs/heads/master@{#12526} TBR=mflodman@webrtc.org,pbos@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5817 Committed: https://crrev.com/0190367cea6f94fc0bff470cfbf9313d9ac0ce94 Cr-Commit-Position: refs/heads/master@{#12534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15144 lines, -4 lines) Patch
M talk/app/webrtc/legacy_objc_api.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/api/api.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/media.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/modules/modules_java.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/modules_java_chromium.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/BUILD.gn View 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/OWNERS View 1 chunk +12 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViEAndroidGLES20.java View 1 chunk +371 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViERenderer.java View 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViESurfaceRenderer.java View 1 chunk +185 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_impl.h View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_impl.cc View 1 chunk +316 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_native_opengl2.h View 1 chunk +95 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_native_opengl2.cc View 1 chunk +450 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_surface_view.h View 1 chunk +83 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_android_surface_view.cc View 1 chunk +474 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_opengles20.h View 1 chunk +57 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/android/video_render_opengles20.cc View 1 chunk +397 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/external/video_render_external_impl.h View 1 chunk +128 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/external/video_render_external_impl.cc View 1 chunk +195 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/i_video_render.h View 1 chunk +129 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/open_gles20.h View 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/open_gles20.mm View 1 chunk +330 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_channel.h View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_channel.mm View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_gles20.h View 1 chunk +87 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_gles20.mm View 1 chunk +285 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_impl.h View 1 chunk +105 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_impl.mm View 1 chunk +170 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_view.h View 1 chunk +34 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/ios/video_render_ios_view.mm View 1 chunk +163 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_render_linux_impl.h View 1 chunk +128 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_render_linux_impl.cc View 1 chunk +261 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_x11_channel.h View 1 chunk +96 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_x11_channel.cc View 1 chunk +315 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_x11_render.h View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/linux/video_x11_render.cc View 1 chunk +153 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/cocoa_full_screen_window.h View 1 chunk +33 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/cocoa_full_screen_window.mm View 1 chunk +87 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/cocoa_render_view.h View 1 chunk +32 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/cocoa_render_view.mm View 1 chunk +55 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_agl.h View 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_agl.cc View 1 chunk +1987 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_mac_carbon_impl.h View 1 chunk +146 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_mac_carbon_impl.cc View 1 chunk +280 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_mac_cocoa_impl.h View 1 chunk +141 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_mac_cocoa_impl.mm View 1 chunk +253 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_nsopengl.h View 1 chunk +192 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/mac/video_render_nsopengl.mm View 1 chunk +1247 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/test/testAPI/renderStartImage.bmp View Binary file 0 comments Download
A webrtc/modules/video_render/test/testAPI/testAPI.h View 1 chunk +18 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/test/testAPI/testAPI.cc View 1 chunk +645 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/test/testAPI/testAPI_android.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/test/testAPI/testAPI_mac.mm View 1 chunk +69 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render.h View 1 chunk +255 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render.gypi View 1 chunk +218 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render_defines.h View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render_impl.h View 1 chunk +208 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render_impl.cc View 1 chunk +550 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render_internal.h View 1 chunk +27 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/video_render_internal_impl.cc View 1 chunk +773 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/windows/i_video_render_win.h View 1 chunk +110 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/windows/video_render_direct3d9.h View 1 chunk +256 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/windows/video_render_direct3d9.cc View 1 chunk +1160 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/windows/video_render_windows_impl.h View 1 chunk +137 lines, -0 lines 0 comments Download
A webrtc/modules/video_render/windows/video_render_windows_impl.cc View 1 chunk +337 lines, -0 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/vie_channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
Created Revert of Delete video_render module.
4 years, 7 months ago (2016-04-27 15:56:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923613003/1
4 years, 7 months ago (2016-04-27 15:56:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 15:56:56 UTC) #4
nisse-webrtc
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1929223003/ by nisse@webrtc.org. ...
4 years, 7 months ago (2016-04-29 06:51:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:00:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0190367cea6f94fc0bff470cfbf9313d9ac0ce94
Cr-Commit-Position: refs/heads/master@{#12534}

Powered by Google App Engine
This is Rietveld 408576698