Delete video_render module.

Delete video_render module.

BUG=webrtc:5817
Committed: https://crrev.com/97cfd1ec05d07ef233356e57f7aa4b028b74ffba
Cr-Commit-Position: refs/heads/master@{#12526}

[nisse-webrtc, 2016-04-22 13:00:22]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 13:00:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912143002/20001

[commit-bot: I haz the power, 2016-04-22 13:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:02:53]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/9232)

[nisse-webrtc, 2016-04-25 09:11:10]

Description was changed from

==========
Delete video_render module.

I get a presubmit error,

  Depending on rtc_base is not allowed. Change your dependency to
  rtc_base_approved and possibly sanitize and move the desired source
  file(s) to rtc_base_approved.
  Changed GYP files:
    webrtc/test/test.gyp

which seems unrelated to this change.

BUG=webrtc:5817
==========

to

==========
Delete video_render module.

BUG=webrtc:5817
==========

[nisse-webrtc, 2016-04-25 09:12:35]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 09:12:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912143002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912143002/200001

[nisse-webrtc, 2016-04-25 09:15:27]

nisse@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[nisse-webrtc, 2016-04-25 09:15:29]

This cl deletes all of the video_render module. Ok?

[pbos-webrtc, 2016-04-25 09:35:51]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-04-25 09:35:52]

LGTM for the modified files, I'll let mflodman@ do the signoff on deletion.

[commit-bot: I haz the power, 2016-04-25 11:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 11:04:48]

Dry run: This issue passed the CQ dry run.

[mflodman, 2016-04-26 06:40:46]

Code LGTM, as long as there are no objections or users of the code.

[nisse-webrtc, 2016-04-27 08:25:56]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-04-27 08:25:57]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1912143002/#ps220001 (title:
"Move -framework flags from legacy_objc_api_tests.gyp to legacy_objc_api.gyp.")

[commit-bot: I haz the power, 2016-04-27 08:26:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912143002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912143002/220001

[commit-bot: I haz the power, 2016-04-27 09:52:22]

Description was changed from

==========
Delete video_render module.

BUG=webrtc:5817
==========

to

==========
Delete video_render module.

BUG=webrtc:5817
==========

[commit-bot: I haz the power, 2016-04-27 09:52:24]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-04-27 09:52:34]

Description was changed from

==========
Delete video_render module.

BUG=webrtc:5817
==========

to

==========
Delete video_render module.

BUG=webrtc:5817

Committed: https://crrev.com/97cfd1ec05d07ef233356e57f7aa4b028b74ffba
Cr-Commit-Position: refs/heads/master@{#12526}
==========

[commit-bot: I haz the power, 2016-04-27 09:52:36]

Patchset 12 (id:??) landed as
https://crrev.com/97cfd1ec05d07ef233356e57f7aa4b028b74ffba
Cr-Commit-Position: refs/heads/master@{#12526}

[kjellander_webrtc, 2016-04-27 15:56:18]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.webrtc.org/1923613003/ by kjellander@webrtc.org.

The reason for reverting is: This breaks every buildbot in chromium.webrtc.fyi
and I don't see any roll in progress to address this (and I don't see how that
would be possible either).
Usage in Chrome:
https://code.google.com/p/chromium/codesearch#search/&q=modules.gyp%3Avideo_r...

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...

I think it's fine to delete our video_render_module_internal_impl target and
those files, but video_render target needs to remain..

[pbos-webrtc, 2016-04-27 19:24:09]

On 2016/04/27 15:56:18, kjellander (webrtc) wrote:
> A revert of this CL (patchset #12 id:220001) has been created in
> https://codereview.webrtc.org/1923613003/ by mailto:kjellander@webrtc.org.
> 
> The reason for reverting is: This breaks every buildbot in chromium.webrtc.fyi
> and I don't see any roll in progress to address this (and I don't see how that
> would be possible either).
> Usage in Chrome:
>
https://code.google.com/p/chromium/codesearch#search/&q=modules.gyp%3Avideo_r...
> 
> Example failures:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build...
> 
> I think it's fine to delete our video_render_module_internal_impl target and
> those files, but video_render target needs to remain..

I don't think it does anymore, but Chromium's libjingle.gyp needs to stop
referring to it first. We moved the essentials out of video_render into
common_video.

[nisse-webrtc, 2016-04-28 06:24:36]

On 2016/04/27 19:24:09, pbos-webrtc wrote:

> I don't think it does anymore, but Chromium's libjingle.gyp needs to stop
> referring to it first. We moved the essentials out of video_render into
> common_video.

I'll try to simply delete the references in chrome's gyp files. Hopefully,
that's enough.
BTW, is this build file duplication only for gyp, or for gn too?

[pbos-webrtc, 2016-04-28 11:14:01]

On 2016/04/28 06:24:36, nisse-webrtc wrote:
> On 2016/04/27 19:24:09, pbos-webrtc wrote:
> 
> > I don't think it does anymore, but Chromium's libjingle.gyp needs to stop
> > referring to it first. We moved the essentials out of video_render into
> > common_video.
> 
> I'll try to simply delete the references in chrome's gyp files. Hopefully,
> that's enough.
> BTW, is this build file duplication only for gyp, or for gn too?

both, there's also third_party/libjingle/BUILD.gn