Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), stefan-webrtc, Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, kwiberg-webrtc, andresp, perkj_webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc@size_t
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[NOT FOR REVIEW] Convert channel counts to size_t. BUG=chromium:81439 TEST=none

Patch Set 1 #

Patch Set 2 : Checkpoint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1098 lines, -1230 lines) Patch
M talk/app/webrtc/mediastreamhandler.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/mediastreamhandler.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsdp.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M talk/media/base/audiorenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/codec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/media/base/codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/fakemediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M webrtc/common_audio/audio_converter_unittest.cc View 7 chunks +20 lines, -18 lines 0 comments Download
M webrtc/common_audio/blocker.h View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/common_audio/blocker.cc View 1 7 chunks +14 lines, -14 lines 0 comments Download
M webrtc/common_audio/blocker_unittest.cc View 10 chunks +56 lines, -56 lines 0 comments Download
M webrtc/common_audio/channel_buffer.h View 8 chunks +10 lines, -10 lines 0 comments Download
M webrtc/common_audio/channel_buffer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/common_audio/lapped_transform.h View 5 chunks +12 lines, -10 lines 0 comments Download
M webrtc/common_audio/lapped_transform.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/common_audio/lapped_transform_unittest.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M webrtc/common_audio/resampler/include/push_resampler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/resampler/include/resampler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/resampler/push_resampler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/common_audio/resampler/resampler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/wav_file.h View 4 chunks +12 lines, -12 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 1 7 chunks +9 lines, -11 lines 0 comments Download
M webrtc/common_audio/wav_file_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/common_audio/wav_header.h View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/common_audio/wav_header.cc View 6 chunks +29 lines, -27 lines 0 comments Download
M webrtc/common_audio/wav_header_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M webrtc/common_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder_mutable_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/include/audio_encoder_cng.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/include/audio_encoder_pcm.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/include/audio_encoder_g722.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/interface/audio_encoder_ilbc.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/interface/opus_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_resampler.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_resampler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/EncodeDecodeTest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/EncodeDecodeTest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/interface/neteq.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 10 chunks +14 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/include/audio_device_defines.h View 1 9 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_device/test/audio_device_test_api.cc View 3 chunks +2 lines, -25 lines 0 comments Download
M webrtc/modules/audio_device/test/func_test_manager.h View 3 chunks +3 lines, -25 lines 0 comments Download
M webrtc/modules/audio_device/test/func_test_manager.cc View 4 chunks +3 lines, -29 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 1 13 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 8 chunks +16 lines, -17 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/complex_matrix.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/matrix.h View 11 chunks +25 lines, -23 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/matrix_test_helpers.h View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/level_estimator_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/level_estimator_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/processing_component.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/processing_component.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/splitting_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/splitting_filter.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 1 47 chunks +90 lines, -96 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 1 4 chunks +15 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 6 chunks +24 lines, -19 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/unpack.cc View 7 chunks +22 lines, -15 lines 0 comments Download
M webrtc/modules/audio_processing/vad/voice_activity_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/interface/module_common_types.h View 1 6 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/media_file/source/media_file_utility.h View 4 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/media_file/source/media_file_utility.cc View 40 chunks +121 lines, -207 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/mock/mock_rtp_payload_strategy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/interface/aligned_array.h View 3 chunks +13 lines, -15 lines 0 comments Download
M webrtc/system_wrappers/source/aligned_array_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 9 chunks +13 lines, -12 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M webrtc/voice_engine/utility.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/utility.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.h View 2 chunks +10 lines, -10 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 7 chunks +13 lines, -14 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 6 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1230503003 Patch 70001

Powered by Google App Engine
This is Rietveld 408576698