webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc - Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@size_t

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

index 50269868588224127305e848a005f1dc350f0e78..36cc96b15ecb48a37f81acbf3b24a018765e661e 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

@@ -23,7 +23,7 @@ using ::testing::Return;

using ::testing::_;

static const char* kTypicalPayloadName = "name";

-static const uint8_t kTypicalChannels = 1;

+static const size_t kTypicalChannels = 1;

static const int kTypicalFrequency = 44000;

static const int kTypicalRate = 32 * 1024;

@@ -90,7 +90,7 @@ TEST_F(RtpPayloadRegistryTest, RegistersAndRemembersPayloadsUntilDeregistered) {

TEST_F(RtpPayloadRegistryTest, AudioRedWorkProperly) {

const uint8_t kRedPayloadType = 127;

const int kRedSampleRate = 8000;

- const int kRedChannels = 1;

+ const size_t kRedChannels = 1;

const int kRedBitRate = 0;

// This creates an audio RTP payload strategy.