webrtc/modules/audio_coding/neteq/neteq_unittest.cc - Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t.

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@size_t

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc ('k') | webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

diff --git a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

index 03fde538898ce8236097a73054de4dee58278787..b8a160b0e28f2b3f8a9790762168d5729decc0c2 100644

--- a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

+++ b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

@@ -353,7 +353,7 @@ void NetEqDecodingTest::Process(size_t* out_len) {

// Get audio from NetEq.

NetEqOutputType type;

- int num_channels;

+ size_t num_channels;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, out_len,

&num_channels, &type));

ASSERT_TRUE((*out_len == kBlockSize8kHz) ||

@@ -500,7 +500,7 @@ TEST_F(NetEqDecodingTestFaxMode, TestFrameWaitingTimeStatistics) {

// Pull out all data.

for (size_t i = 0; i < num_frames; ++i) {

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, &out_len,

&num_channels, &type));

@@ -538,7 +538,7 @@ TEST_F(NetEqDecodingTestFaxMode, TestFrameWaitingTimeStatistics) {

reinterpret_cast<uint8_t*>(payload),

kPayloadBytes, 0));

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, &out_len,

&num_channels, &type));

@@ -568,7 +568,7 @@ TEST_F(NetEqDecodingTest, TestAverageInterArrivalTimeNegative) {

// Pull out data once.

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, &out_len,

&num_channels, &type));

@@ -599,7 +599,7 @@ TEST_F(NetEqDecodingTest, TestAverageInterArrivalTimePositive) {

// Pull out data once.

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, &out_len,

&num_channels, &type));

@@ -624,7 +624,7 @@ void NetEqDecodingTest::LongCngWithClockDrift(double drift_factor,

double next_input_time_ms = 0.0;

double t_ms;

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

// Insert speech for 5 seconds.

@@ -854,7 +854,7 @@ TEST_F(NetEqDecodingTest, DISABLED_ON_ANDROID(DecoderError)) {

for (size_t i = 0; i < kMaxBlockSize; ++i) {

out_data_[i] = 1;

}

- int num_channels;

+ size_t num_channels;

size_t samples_per_channel;

EXPECT_EQ(NetEq::kFail,

neteq_->GetAudio(kMaxBlockSize, out_data_,

@@ -887,7 +887,7 @@ TEST_F(NetEqDecodingTest, GetAudioBeforeInsertPacket) {

for (size_t i = 0; i < kMaxBlockSize; ++i) {

out_data_[i] = 1;

}

- int num_channels;

+ size_t num_channels;

size_t samples_per_channel;

EXPECT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_,

&samples_per_channel,

@@ -941,7 +941,7 @@ class NetEqBgnTest : public NetEqDecodingTest {

PopulateRtpInfo(0, 0, &rtp_info);

rtp_info.header.payloadType = payload_type;

- int number_channels = 0;

+ size_t number_channels = 0;

size_t samples_per_channel = 0;

uint32_t receive_timestamp = 0;

@@ -961,7 +961,7 @@ class NetEqBgnTest : public NetEqDecodingTest {

&samples_per_channel,

&number_channels,

&type));

- ASSERT_EQ(1, number_channels);

+ ASSERT_EQ(1u, number_channels);

ASSERT_EQ(expected_samples_per_channel, samples_per_channel);

ASSERT_EQ(kOutputNormal, type);

@@ -983,7 +983,7 @@ class NetEqBgnTest : public NetEqDecodingTest {

&samples_per_channel,

&number_channels,

&type));

- ASSERT_EQ(1, number_channels);

+ ASSERT_EQ(1u, number_channels);

ASSERT_EQ(expected_samples_per_channel, samples_per_channel);

// To be able to test the fading of background noise we need at lease to

@@ -1004,7 +1004,7 @@ class NetEqBgnTest : public NetEqDecodingTest {

&samples_per_channel,

&number_channels,

&type));

- ASSERT_EQ(1, number_channels);

+ ASSERT_EQ(1u, number_channels);

ASSERT_EQ(expected_samples_per_channel, samples_per_channel);

if (type == kOutputPLCtoCNG) {

plc_to_cng = true;

@@ -1167,7 +1167,7 @@ TEST_F(NetEqDecodingTest, SyncPacketDecode) {

// Insert some packets which decode to noise. We are not interested in

// actual decoded values.

NetEqOutputType output_type;

- int num_channels;

+ size_t num_channels;

size_t samples_per_channel;

uint32_t receive_timestamp = 0;

for (int n = 0; n < 100; ++n) {

@@ -1177,7 +1177,7 @@ TEST_F(NetEqDecodingTest, SyncPacketDecode) {

&samples_per_channel, &num_channels,

&output_type));

ASSERT_EQ(kBlockSize16kHz, samples_per_channel);

- ASSERT_EQ(1, num_channels);

+ ASSERT_EQ(1u, num_channels);

rtp_info.header.sequenceNumber++;

rtp_info.header.timestamp += kBlockSize16kHz;

@@ -1195,7 +1195,7 @@ TEST_F(NetEqDecodingTest, SyncPacketDecode) {

&samples_per_channel, &num_channels,

&output_type));

ASSERT_EQ(kBlockSize16kHz, samples_per_channel);

- ASSERT_EQ(1, num_channels);

+ ASSERT_EQ(1u, num_channels);

if (n > algorithmic_frame_delay) {

EXPECT_TRUE(IsAllZero(decoded, samples_per_channel * num_channels));

}

@@ -1245,7 +1245,7 @@ TEST_F(NetEqDecodingTest, SyncPacketBufferSizeAndOverridenByNetworkPackets) {

// Insert some packets which decode to noise. We are not interested in

// actual decoded values.

NetEqOutputType output_type;

- int num_channels;

+ size_t num_channels;

size_t samples_per_channel;

uint32_t receive_timestamp = 0;

int algorithmic_frame_delay = algorithmic_delay_ms_ / 10 + 1;

@@ -1256,7 +1256,7 @@ TEST_F(NetEqDecodingTest, SyncPacketBufferSizeAndOverridenByNetworkPackets) {

&samples_per_channel, &num_channels,

&output_type));

ASSERT_EQ(kBlockSize16kHz, samples_per_channel);

- ASSERT_EQ(1, num_channels);

+ ASSERT_EQ(1u, num_channels);

rtp_info.header.sequenceNumber++;

rtp_info.header.timestamp += kBlockSize16kHz;

receive_timestamp += kBlockSize16kHz;

@@ -1296,7 +1296,7 @@ TEST_F(NetEqDecodingTest, SyncPacketBufferSizeAndOverridenByNetworkPackets) {

&samples_per_channel, &num_channels,

&output_type));

ASSERT_EQ(kBlockSize16kHz, samples_per_channel);

- ASSERT_EQ(1, num_channels);

+ ASSERT_EQ(1u, num_channels);

EXPECT_TRUE(IsAllNonZero(decoded, samples_per_channel * num_channels));

}

@@ -1314,7 +1314,7 @@ void NetEqDecodingTest::WrapTest(uint16_t start_seq_no,

const size_t kPayloadBytes = kSamples * sizeof(int16_t);

double next_input_time_ms = 0.0;

int16_t decoded[kBlockSize16kHz];

- int num_channels;

+ size_t num_channels;

size_t samples_per_channel;

NetEqOutputType output_type;

uint32_t receive_timestamp = 0;

@@ -1368,7 +1368,7 @@ void NetEqDecodingTest::WrapTest(uint16_t start_seq_no,

&samples_per_channel, &num_channels,

&output_type));

ASSERT_EQ(kBlockSize16kHz, samples_per_channel);

- ASSERT_EQ(1, num_channels);

+ ASSERT_EQ(1u, num_channels);

// Expect delay (in samples) to be less than 2 packets.

EXPECT_LE(timestamp - PlayoutTimestamp(),

@@ -1419,7 +1419,7 @@ void NetEqDecodingTest::DuplicateCng() {

// Insert three speech packets. Three are needed to get the frame length

// correct.

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

uint8_t payload[kPayloadBytes] = {0};

WebRtcRTPHeader rtp_info;

@@ -1516,7 +1516,7 @@ TEST_F(NetEqDecodingTest, CngFirst) {

// Pull audio once and make sure CNG is played.

size_t out_len;

- int num_channels;

+ size_t num_channels;

NetEqOutputType type;

ASSERT_EQ(0, neteq_->GetAudio(kMaxBlockSize, out_data_, &out_len,

&num_channels, &type));