webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h - Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h

Issue 1238083005: [NOT FOR REVIEW] Convert channel counts to size_t. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@size_t

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('k') | webrtc/modules/audio_coding/codecs/opus/interface/opus_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h b/webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h

index 5fab599fe1ae42e749fb5aa490612e42433bf36d..d9b74f37b5d0f5de554c54e8cb00b20ce792c91c 100644

--- a/webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h

+++ b/webrtc/modules/audio_coding/codecs/opus/interface/audio_encoder_opus.h

@@ -34,7 +34,7 @@ class AudioEncoderOpus final : public AudioEncoder {

Config();

bool IsOk() const;

int frame_size_ms;

- int num_channels;

+ size_t num_channels;

int payload_type;

ApplicationMode application;

int bitrate_bps;

@@ -48,7 +48,7 @@ class AudioEncoderOpus final : public AudioEncoder {

~AudioEncoderOpus() override;

int SampleRateHz() const override;

- int NumChannels() const override;

+ size_t NumChannels() const override;

size_t MaxEncodedBytes() const override;

size_t Num10MsFramesInNextPacket() const override;

size_t Max10MsFramesInAPacket() const override;

@@ -67,7 +67,7 @@ class AudioEncoderOpus final : public AudioEncoder {

private:

const size_t num_10ms_frames_per_packet_;

- const int num_channels_;

+ const size_t num_channels_;

const int payload_type_;

const ApplicationMode application_;

int bitrate_bps_;