Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 3011013002: Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. (Closed)

Created:
3 years, 3 months ago by Zach Stein
Modified:
3 years, 3 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, daniela-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/3011013002 Cr-Commit-Position: refs/heads/master@{#19697} Committed: https://chromium.googlesource.com/external/webrtc/+/8b476173d897c8e88330de683f9f9e9c81e76589

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comment style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnection.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h View 1 2 chunks +9 lines, -8 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zach Stein
Addressing feedback from https://codereview.webrtc.org/2877933004/.
3 years, 3 months ago (2017-09-05 20:44:03 UTC) #2
tkchin_webrtc
Thanks for addressing feedback. lgtm % nits https://codereview.webrtc.org/3011013002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h (right): https://codereview.webrtc.org/3011013002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h#newcode188 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h:188: * Limits ...
3 years, 3 months ago (2017-09-05 20:51:51 UTC) #3
Zach Stein
https://codereview.webrtc.org/3011013002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h (right): https://codereview.webrtc.org/3011013002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h#newcode188 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h:188: * Limits the bandwidth allocated for all RTP streams ...
3 years, 3 months ago (2017-09-05 21:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011013002/20001
3 years, 3 months ago (2017-09-05 21:15:29 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 21:43:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8b476173d897c8e88330de683...

Powered by Google App Engine
This is Rietveld 408576698