Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Issue 3011013002: Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. (Closed)
Patch Set: Fix comment style. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 /** Apply the supplied RTCSessionDescription as the local description. */ 177 /** Apply the supplied RTCSessionDescription as the local description. */
178 - (void)setLocalDescription:(RTCSessionDescription *)sdp 178 - (void)setLocalDescription:(RTCSessionDescription *)sdp
179 completionHandler: 179 completionHandler:
180 (nullable void (^)(NSError * _Nullable error))completionHandler; 180 (nullable void (^)(NSError * _Nullable error))completionHandler;
181 181
182 /** Apply the supplied RTCSessionDescription as the remote description. */ 182 /** Apply the supplied RTCSessionDescription as the remote description. */
183 - (void)setRemoteDescription:(RTCSessionDescription *)sdp 183 - (void)setRemoteDescription:(RTCSessionDescription *)sdp
184 completionHandler: 184 completionHandler:
185 (nullable void (^)(NSError * _Nullable error))completionHandler; 185 (nullable void (^)(NSError * _Nullable error))completionHandler;
186 186
187 /** Updates bandwidth estimation parameters. Null parameters will be unchanged. 187 /** Limits the bandwidth allocated for all RTP streams sent by this
188 * Returns true iff the parameters were successfully updated. 188 * PeerConnection. Nil parameters will be unchanged. Setting
189 * |currentBitrateBps| will force the available bitrate estimate to the given
190 * value. Returns YES if the parameters were successfully updated.
189 */ 191 */
190 - (BOOL)setBitrateToMin:(NSNumber *_Nullable)minBitrateBps 192 - (BOOL)setBweMinBitrateBps:(nullable NSNumber *)minBitrateBps
191 toCurrent:(NSNumber *_Nullable)currentBitrateBps 193 currentBitrateBps:(nullable NSNumber *)currentBitrateBps
192 toMax:(NSNumber *_Nullable)maxBitrateBps; 194 maxBitrateBps:(nullable NSNumber *)maxBitrateBps;
193 195
194 /** Start or stop recording an Rtc EventLog. */ 196 /** Start or stop recording an Rtc EventLog. */
195 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath 197 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath
196 maxSizeInBytes:(int64_t)maxSizeInBytes; 198 maxSizeInBytes:(int64_t)maxSizeInBytes;
197 - (void)stopRtcEventLog; 199 - (void)stopRtcEventLog;
198 200
199 @end 201 @end
200 202
201 @interface RTCPeerConnection (Media) 203 @interface RTCPeerConnection (Media)
202 204
203 /** 205 /** Create an RTCRtpSender with the specified kind and media stream ID.
204 * Create an RTCRtpSender with the specified kind and media stream ID. 206 * See RTCMediaStreamTrack.h for available kinds.
205 * See RTCMediaStreamTrack.h for available kinds.
206 */ 207 */
207 - (RTCRtpSender *)senderWithKind:(NSString *)kind streamId:(NSString *)streamId; 208 - (RTCRtpSender *)senderWithKind:(NSString *)kind streamId:(NSString *)streamId;
208 209
209 @end 210 @end
210 211
211 @interface RTCPeerConnection (DataChannel) 212 @interface RTCPeerConnection (DataChannel)
212 213
213 /** Create a new data channel with the given label and configuration. */ 214 /** Create a new data channel with the given label and configuration. */
214 - (RTCDataChannel *)dataChannelForLabel:(NSString *)label 215 - (RTCDataChannel *)dataChannelForLabel:(NSString *)label
215 configuration:(RTCDataChannelConfiguration *)configuration; 216 configuration:(RTCDataChannelConfiguration *)configuration;
216 217
217 @end 218 @end
218 219
219 @interface RTCPeerConnection (Stats) 220 @interface RTCPeerConnection (Stats)
220 221
221 /** Gather stats for the given RTCMediaStreamTrack. If |mediaStreamTrack| is nil 222 /** Gather stats for the given RTCMediaStreamTrack. If |mediaStreamTrack| is nil
222 * statistics are gathered for all tracks. 223 * statistics are gathered for all tracks.
223 */ 224 */
224 - (void)statsForTrack: 225 - (void)statsForTrack:
225 (nullable RTCMediaStreamTrack *)mediaStreamTrack 226 (nullable RTCMediaStreamTrack *)mediaStreamTrack
226 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel 227 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
227 completionHandler: 228 completionHandler:
228 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ; 229 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ;
229 230
230 @end 231 @end
231 232
232 NS_ASSUME_NONNULL_END 233 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698