Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Issue 3011013002: Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 /** Apply the supplied RTCSessionDescription as the local description. */ 177 /** Apply the supplied RTCSessionDescription as the local description. */
178 - (void)setLocalDescription:(RTCSessionDescription *)sdp 178 - (void)setLocalDescription:(RTCSessionDescription *)sdp
179 completionHandler: 179 completionHandler:
180 (nullable void (^)(NSError * _Nullable error))completionHandler; 180 (nullable void (^)(NSError * _Nullable error))completionHandler;
181 181
182 /** Apply the supplied RTCSessionDescription as the remote description. */ 182 /** Apply the supplied RTCSessionDescription as the remote description. */
183 - (void)setRemoteDescription:(RTCSessionDescription *)sdp 183 - (void)setRemoteDescription:(RTCSessionDescription *)sdp
184 completionHandler: 184 completionHandler:
185 (nullable void (^)(NSError * _Nullable error))completionHandler; 185 (nullable void (^)(NSError * _Nullable error))completionHandler;
186 186
187 /** Updates bandwidth estimation parameters. Null parameters will be unchanged. 187 /**
188 * Returns true iff the parameters were successfully updated. 188 * Limits the bandwidth allocated for all RTP streams sent by this
tkchin_webrtc 2017/09/05 20:51:51 nit: move first word after /** to match methods ab
Zach Stein 2017/09/05 21:14:41 Done.
189 * PeerConnection. Nil parameters will be unchanged. Setting
190 * |currentBitrateBps| will force the available bitrate estimate to the given
tkchin_webrtc 2017/09/05 20:51:51 for my own education - will bitrate estimate conti
Zach Stein 2017/09/05 21:14:41 Yes.
191 * value. Returns YES if the parameters were successfully updated.
189 */ 192 */
190 - (BOOL)setBitrateToMin:(NSNumber *_Nullable)minBitrateBps 193 - (BOOL)setBweMinBitrateBps:(nullable NSNumber *)minBitrateBps
191 toCurrent:(NSNumber *_Nullable)currentBitrateBps 194 currentBitrateBps:(nullable NSNumber *)currentBitrateBps
192 toMax:(NSNumber *_Nullable)maxBitrateBps; 195 maxBitrateBps:(nullable NSNumber *)maxBitrateBps;
193 196
194 /** Start or stop recording an Rtc EventLog. */ 197 /** Start or stop recording an Rtc EventLog. */
195 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath 198 - (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath
196 maxSizeInBytes:(int64_t)maxSizeInBytes; 199 maxSizeInBytes:(int64_t)maxSizeInBytes;
197 - (void)stopRtcEventLog; 200 - (void)stopRtcEventLog;
198 201
199 @end 202 @end
200 203
201 @interface RTCPeerConnection (Media) 204 @interface RTCPeerConnection (Media)
202 205
(...skipping 20 matching lines...) Expand all
223 */ 226 */
224 - (void)statsForTrack: 227 - (void)statsForTrack:
225 (nullable RTCMediaStreamTrack *)mediaStreamTrack 228 (nullable RTCMediaStreamTrack *)mediaStreamTrack
226 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel 229 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
227 completionHandler: 230 completionHandler:
228 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ; 231 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ;
229 232
230 @end 233 @end
231 234
232 NS_ASSUME_NONNULL_END 235 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698