Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm

Issue 3011013002: Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. (Closed)
Patch Set: Fix comment style. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm
diff --git a/webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm b/webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm
index 429962df4bc8b80f81c775db5af9fc4a37b7a1aa..bf3fc33439021ac8aa63a2fad75a16794542d438 100644
--- a/webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm
+++ b/webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm
@@ -60,12 +60,12 @@
[factory peerConnectionWithConfiguration:config constraints:contraints delegate:nil];
newConfig = peerConnection.configuration;
- EXPECT_TRUE([peerConnection setBitrateToMin:[NSNumber numberWithInt:100000]
- toCurrent:[NSNumber numberWithInt:5000000]
- toMax:[NSNumber numberWithInt:500000000]]);
- EXPECT_FALSE([peerConnection setBitrateToMin:[NSNumber numberWithInt:2]
- toCurrent:[NSNumber numberWithInt:1]
- toMax:nullptr]);
+ EXPECT_TRUE([peerConnection setBweMinBitrateBps:[NSNumber numberWithInt:100000]
+ currentBitrateBps:[NSNumber numberWithInt:5000000]
+ maxBitrateBps:[NSNumber numberWithInt:500000000]]);
+ EXPECT_FALSE([peerConnection setBweMinBitrateBps:[NSNumber numberWithInt:2]
+ currentBitrateBps:[NSNumber numberWithInt:1]
+ maxBitrateBps:nil]);
}
EXPECT_EQ([config.iceServers count], [newConfig.iceServers count]);
« no previous file with comments | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698