Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 3004583002: Change frame bookkeeping in VideoProcessorIntegrationTest. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change frame bookkeeping in VideoProcessorIntegrationTest. Now we always process |rate_profile.num_frames| number of frames. This means that the output of the tests in videoprocessor_integrationtest.cc will be slightly different, as we will no process 300 frames, instead of 299. No rate control or quality thresholds need to be updated, however. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3004583002 Cr-Commit-Position: refs/heads/master@{#19515} Committed: https://chromium.googlesource.com/external/webrtc/+/ee95f874885a8489bebc54bae9c3bec26884f858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 2 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
brandtr
Split out two CLs from https://codereview.webrtc.org/2997283002/.
3 years, 4 months ago (2017-08-25 07:51:46 UTC) #2
åsapersson
lgtm
3 years, 4 months ago (2017-08-25 09:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004583002/1
3 years, 4 months ago (2017-08-25 11:49:29 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-25 11:52:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ee95f874885a8489bebc54bae...

Powered by Google App Engine
This is Rietveld 408576698