Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 3008543002: Make rate control and quality thresholds optional in VideoProcessorIntegrationTest. (Closed)

Created:
3 years, 3 months ago by brandtr
Modified:
3 years, 3 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rate control and quality thresholds optional in VideoProcessorIntegrationTest. This CL is split out from https://codereview.webrtc.org/2997283002/. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3008543002 Cr-Commit-Position: refs/heads/master@{#19513} Committed: https://chromium.googlesource.com/external/webrtc/+/87f5c5a4d366da90ca8239b54e25d4d9ec6c1364

Patch Set 1 #

Total comments: 3

Patch Set 2 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -260 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 2 chunks +8 lines, -29 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 13 chunks +62 lines, -54 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 12 chunks +181 lines, -177 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
brandtr
Split out two CLs from https://codereview.webrtc.org/2997283002/
3 years, 3 months ago (2017-08-25 07:51:25 UTC) #4
åsapersson
lgtm https://codereview.webrtc.org/3008543002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/3008543002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc#newcode426 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:426: SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, nit: maybe move ...
3 years, 3 months ago (2017-08-25 09:17:05 UTC) #5
brandtr
https://codereview.webrtc.org/3008543002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h (right): https://codereview.webrtc.org/3008543002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h#newcode473 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:473: // e.g., when we are operating in batch mode. ...
3 years, 3 months ago (2017-08-25 11:04:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3008543002/60001
3 years, 3 months ago (2017-08-25 11:04:17 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-08-25 11:33:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/87f5c5a4d366da90ca8239b54...

Powered by Google App Engine
This is Rietveld 408576698