VideoProcessorIntegrationTest: make it runnable on a task queue.

VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2997283002
Cr-Commit-Position: refs/heads/master@{#19604}
Committed: https://chromium.googlesource.com/external/webrtc/+/b57f42676e92db62b04a075a1cf127edb430cf82

[brandtr, 2017-08-21 14:14:36]

Patchset #1 (id:1) has been deleted

[brandtr, 2017-08-22 07:45:21]

Patchset #1 (id:20001) has been deleted

[brandtr, 2017-08-22 09:41:29]

Patchset #1 (id:40001) has been deleted

[brandtr, 2017-08-22 09:50:25]

Patchset #1 (id:60001) has been deleted

[brandtr, 2017-08-22 11:21:10]

Change unit tests a bit.

[brandtr, 2017-08-22 11:27:20]

Description was changed from

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* Split up frame processing from rate control statistics calculations.
* Remove batch mode, since it is no longer needed due to the change above.
* Refactor frame counting, so that we always process
  |rate_profile.num_frames| number of frames.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Simplify the test helper functions for threshold setting.
* Make the thresholds optional.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

to

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Remove batch mode, since it is no longer needed due to
  the change above.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Refactor frame counting, so that we always process
  |rate_profile.num_frames| number of frames. This means that the
  output of the tests in videoprocessor_integrationtest.cc will
  be slightly different, as we will no process 300 frames, instead
  of 299.
* Simplify the test helper functions for threshold setting and
  make the setting of thresholds optional.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

[brandtr, 2017-08-22 11:47:56]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[brandtr, 2017-08-22 11:47:57]

Will currently not run on iOS with HW codecs, but separate changes to the
wrapper will make that possible.

[brandtr, 2017-08-24 07:32:50]

Rebase.

[brandtr, 2017-08-24 10:18:56]

Simplified the test loop a tiny bit. Text output is still (basically) unchanged
before and after this CL.

[brandtr, 2017-08-25 06:50:33]

Rebase.

[brandtr, 2017-08-25 07:43:48]

Description was changed from

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Remove batch mode, since it is no longer needed due to
  the change above.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Refactor frame counting, so that we always process
  |rate_profile.num_frames| number of frames. This means that the
  output of the tests in videoprocessor_integrationtest.cc will
  be slightly different, as we will no process 300 frames, instead
  of 299.
* Simplify the test helper functions for threshold setting and
  make the setting of thresholds optional.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

to

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Remove batch mode, since it is no longer needed due to
  the change above.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

[brandtr, 2017-08-25 11:35:52]

Split out the deletion of batch mode to another CL.

[brandtr, 2017-08-25 11:42:07]

Description was changed from

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Remove batch mode, since it is no longer needed due to
  the change above.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

to

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

[brandtr, 2017-08-25 11:53:39]

Rebase.

[brandtr, 2017-08-25 13:37:12]

Readd missing spaces.

[brandtr, 2017-08-25 14:24:15]

Explicitly set minBitrate and initial frame rate.

[brandtr, 2017-08-29 08:38:21]

Rebase.

[brandtr, 2017-08-29 12:03:42]

Rebase.

[åsapersson, 2017-08-29 13:42:34]

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:601:
0.5 * kInitialBufferSize * bitrate_layer_[0];
maybe move to ResetRateControlMetrics?

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:625:
rate_profile.frame_index_rate_update[rate_update_index + 1]);
call ResetRateControlMetrics from UpdateRates?

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc (right):

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc:169:
EXPECT_EQ(0, video_processor_->NumberDroppedFramesPerRateUpdate()[0]);
maybe EXPECT_THAT(video_processor_->NumberDroppedFramesPerRateUpdate(),
ElementsAre(0))

[brandtr, 2017-08-30 11:08:23]

Rebase.

[brandtr, 2017-08-30 11:08:29]

Patchset #14 (id:340001) has been deleted

[brandtr, 2017-08-30 11:27:48]

Patchset #15 (id:380001) has been deleted

[brandtr, 2017-08-30 11:32:45]

Patchset #15 (id:400001) has been deleted

[brandtr, 2017-08-30 11:44:26]

Addressed comments.

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:601:
0.5 * kInitialBufferSize * bitrate_layer_[0];
On 2017/08/29 13:42:33, åsapersson wrote:
> maybe move to ResetRateControlMetrics?

Done.

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:625:
rate_profile.frame_index_rate_update[rate_update_index + 1]);
On 2017/08/29 13:42:33, åsapersson wrote:
> call ResetRateControlMetrics from UpdateRates?

Done: merged the two functions into one.

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc (right):

https://codereview.webrtc.org/2997283002/diff/320001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc:169:
EXPECT_EQ(0, video_processor_->NumberDroppedFramesPerRateUpdate()[0]);
On 2017/08/29 13:42:33, åsapersson wrote:
> maybe EXPECT_THAT(video_processor_->NumberDroppedFramesPerRateUpdate(),
> ElementsAre(0))

Done.

[åsapersson, 2017-08-30 12:35:01]

lgtm

[brandtr, 2017-08-30 12:52:45]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-30 12:52:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-30 13:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-30 13:25:41]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-08-30 13:27:37]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-08-30 13:27:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-30 13:29:51]

CQ is committing da patch.

Bot data: {"patchset_id": 420001, "attempt_start_ts": 1504099657789880,
"parent_rev": "cd8b079afb1859a7579cfc9a9fc8af3a2fef6673", "commit_rev":
"b57f42676e92db62b04a075a1cf127edb430cf82"}

[commit-bot: I haz the power, 2017-08-30 13:29:56]

Description was changed from

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634
==========

to

==========
VideoProcessorIntegrationTest: make it runnable on a task queue.

* First do all frame processing, then do all rate control
  statistics calculations. This means that we only need to
  synchronize once.
* Run the VideoProcessor on a task queue, thus supporting Android
  HW codecs.
* Add some unit tests for the VideoProcessor.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2997283002
Cr-Commit-Position: refs/heads/master@{#19604}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b57f42676e92db62b04a075a1...
==========

[commit-bot: I haz the power, 2017-08-30 13:29:57]

Committed patchset #15 (id:420001) as
https://chromium.googlesource.com/external/webrtc/+/b57f42676e92db62b04a075a1...