Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

Issue 3004583002: Change frame bookkeeping in VideoProcessorIntegrationTest. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
index 60058eea25360cfc6fdb472c80827aba7679f604..d5471d90edbd0328153474006ee5f8c7eab516f8 100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
@@ -500,9 +500,7 @@ class VideoProcessorIntegrationTest : public testing::Test {
// In batch mode, we calculate the metrics for all frames after all frames
// have been sent for encoding.
- // TODO(brandtr): Refactor "frame number accounting" so we don't have to
- // call ProcessFrame num_frames+1 times here.
- for (frame_number = 0; frame_number <= num_frames; ++frame_number) {
+ for (frame_number = 0; frame_number < num_frames; ++frame_number) {
processor_->ProcessFrame(frame_number);
}
@@ -547,16 +545,13 @@ class VideoProcessorIntegrationTest : public testing::Test {
processor_->SetRates(bitrate_kbps_, framerate_);
}
}
- // TODO(brandtr): Refactor "frame number accounting" so we don't have to
- // call ProcessFrame one extra time here.
- processor_->ProcessFrame(frame_number);
}
// Verify rate control metrics for all frames (if in batch mode), or for all
// frames since the last rate update (if not in batch mode).
PrintAndMaybeVerifyRateControlMetrics(update_index, rc_thresholds);
EXPECT_EQ(num_frames, frame_number);
- EXPECT_EQ(num_frames + 1, static_cast<int>(stats_.stats_.size()));
+ EXPECT_EQ(num_frames, static_cast<int>(stats_.stats_.size()));
// Release encoder and decoder to make sure they have finished processing.
processor_->Release();

Powered by Google App Engine
This is Rietveld 408576698