Make CodecType conversion functions non-optional.

Make CodecType conversion functions non-optional.

We can't handle no value here anyway and end up setting a default
at each call site. The defaults aren't even the same in each place.

BUG=None

Review-Url: https://codereview.webrtc.org/2998293002
Cr-Commit-Position: refs/heads/master@{#19485}
Committed: https://chromium.googlesource.com/external/webrtc/+/1cdddc96fa2f81219bb363f540af8dfb822afbb3

[kthelgason, 2017-08-23 09:25:19]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 09:25:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-23 09:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 09:32:56]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/26938)

[kthelgason, 2017-08-23 11:25:46]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 11:25:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-08-23 11:31:52]

kthelgason@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kthelgason, 2017-08-23 11:31:53]

PTAL when time allows.

[commit-bot: I haz the power, 2017-08-23 12:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 12:22:47]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-08-23 13:14:57]

lgtm

[kthelgason, 2017-08-24 08:06:30]

Patchset #3 (id:40001) has been deleted

[kthelgason, 2017-08-24 08:07:14]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-24 08:07:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 09:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-24 09:06:54]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2017-08-24 10:50:00]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-08-24 10:50:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2998293002/#ps60001 (title:
"Keep old functions for backwards-compat")

[commit-bot: I haz the power, 2017-08-24 10:50:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-24 10:52:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503571800613070,
"parent_rev": "821e21402d84373f790d106c1f017cd9adb8ce3d", "commit_rev":
"1cdddc96fa2f81219bb363f540af8dfb822afbb3"}

[commit-bot: I haz the power, 2017-08-24 10:53:04]

Description was changed from

==========
Make CodecType conversion functions non-optional.

We can't handle no value here anyway and end up setting a default
at each call site. The defaults aren't even the same in each place.

BUG=None
==========

to

==========
Make CodecType conversion functions non-optional.

We can't handle no value here anyway and end up setting a default
at each call site. The defaults aren't even the same in each place.

BUG=None

Review-Url: https://codereview.webrtc.org/2998293002
Cr-Commit-Position: refs/heads/master@{#19485}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1cdddc96fa2f81219bb363f54...
==========

[commit-bot: I haz the power, 2017-08-24 10:53:05]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/1cdddc96fa2f81219bb363f54...