webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h - Issue 2998293002: Make CodecType conversion functions non-optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)

Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/test/videoprocessor.cc ('k') | webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

index 8bcc53d6d52ecb7756d46f31d406848ba24919b6..e47df371f67c7e99b2651b1ca409aa227f03c17b 100644

--- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h

@@ -199,8 +199,7 @@ class VideoProcessorIntegrationTest : public testing::Test {

if (visualization_params) {

const std::string codec_name =

- CodecTypeToPayloadName(config_.codec_settings.codecType)

- .value_or("unknown");

+ CodecTypeToPayloadString(config_.codec_settings.codecType);

const std::string implementation_type = config_.hw_codec ? "hw" : "sw";

// clang-format off

const std::string output_filename_base =