webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc - Issue 2998293002: Make CodecType conversion functions non-optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)

Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h ('k') | webrtc/modules/video_coding/packet.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc

diff --git a/webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc b/webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc

index 90ddcfee02f66c8f8dae6b730904043b1c1fbbe6..48929b9df97f81bfcf4fd147e7cb10f62a926d3a 100644

--- a/webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc

+++ b/webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc

@@ -411,8 +411,7 @@ void PrintPythonOutput(const webrtc::test::TestConfig& config,

ExcludeFrameTypesToStr(config.exclude_frame_types),

config.frame_length_in_bytes, config.use_single_core ? "True " : "False",

config.keyframe_interval,

- CodecTypeToPayloadName(config.codec_settings.codecType)

- .value_or("Unknown"),

+ CodecTypeToPayloadString(config.codec_settings.codecType),

config.codec_settings.width, config.codec_settings.height,

config.codec_settings.startBitrate);

printf(

« no previous file with comments | « webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h ('k') | webrtc/modules/video_coding/packet.cc » ('j') | no next file with comments »