Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: webrtc/common_types.h

Issue 2998293002: Make CodecType conversion functions non-optional. (Closed)
Patch Set: Keep old functions for backwards-compat Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/common_types.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 kVideoCodecH264, 530 kVideoCodecH264,
531 kVideoCodecI420, 531 kVideoCodecI420,
532 kVideoCodecRED, 532 kVideoCodecRED,
533 kVideoCodecULPFEC, 533 kVideoCodecULPFEC,
534 kVideoCodecFlexfec, 534 kVideoCodecFlexfec,
535 kVideoCodecGeneric, 535 kVideoCodecGeneric,
536 kVideoCodecUnknown 536 kVideoCodecUnknown
537 }; 537 };
538 538
539 // Translates from name of codec to codec type and vice versa. 539 // Translates from name of codec to codec type and vice versa.
540 const char* CodecTypeToPayloadString(VideoCodecType type);
541 VideoCodecType PayloadStringToCodecType(const std::string& name);
542 // TODO(kthelgason): Remove these methods once upstream projects
543 // have been updated.
540 rtc::Optional<const char*> CodecTypeToPayloadName(VideoCodecType type); 544 rtc::Optional<const char*> CodecTypeToPayloadName(VideoCodecType type);
541 rtc::Optional<VideoCodecType> PayloadNameToCodecType(const std::string& name); 545 rtc::Optional<VideoCodecType> PayloadNameToCodecType(const std::string& name);
542 546
543 union VideoCodecUnion { 547 union VideoCodecUnion {
544 VideoCodecVP8 VP8; 548 VideoCodecVP8 VP8;
545 VideoCodecVP9 VP9; 549 VideoCodecVP9 VP9;
546 VideoCodecH264 H264; 550 VideoCodecH264 H264;
547 }; 551 };
548 552
549 // Simulcast is when the same stream is encoded multiple times with different 553 // Simulcast is when the same stream is encoded multiple times with different
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
947 bool operator==(const RtpKeepAliveConfig& o) const { 951 bool operator==(const RtpKeepAliveConfig& o) const {
948 return timeout_interval_ms == o.timeout_interval_ms && 952 return timeout_interval_ms == o.timeout_interval_ms &&
949 payload_type == o.payload_type; 953 payload_type == o.payload_type;
950 } 954 }
951 bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); } 955 bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); }
952 }; 956 };
953 957
954 } // namespace webrtc 958 } // namespace webrtc
955 959
956 #endif // WEBRTC_COMMON_TYPES_H_ 960 #endif // WEBRTC_COMMON_TYPES_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/common_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698