Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.

Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.

This is done in anticipation of proto format changes that will use different types for incoming and outgoing packets. This CL makes the interface more natural for the new event log implementation, and it is just as natural for the current implementation. (Note that the current format actually has fields that are only used for outgoing packets. However, we're not changing the encoding or implementation in this CL, merely adding a thin wrapper around the old code.)

BUG=webrtc:8111

[terelius, 2017-08-17 15:37:34]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-17 15:37:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-08-17 15:54:26]

terelius@webrtc.org changed reviewers:
+ eladalon@webrtc.org

[commit-bot: I haz the power, 2017-08-17 15:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-17 15:57:02]

Dry run: Try jobs failed on following builders:
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)

[eladalon, 2017-08-18 08:54:37]

lgtm % I would suggest extending the CL's description with an explanation of why
this was done, and why some of the things we've discussed offline were not done.

[terelius, 2017-08-18 11:08:33]

Description was changed from

==========
Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and
outgoing packets.

BUG=webrtc:8111
==========

to

==========
Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and
outgoing packets.

This is done in anticipation of proto format changes that will use different
types for incoming and outgoing packets. This CL makes the interface more
natural for the new event log implementation, and it is just as natural for the
current implementation. (Note that the current format actually has fields that
are only used for outgoing packets. However, we're not changing the encoding or
implementation in this CL, merely adding a thin wrapper around the old code.)

BUG=webrtc:8111
==========

[terelius, 2017-08-18 11:08:34]

terelius@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[terelius, 2017-08-18 11:12:16]

terelius@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[terelius, 2017-08-18 11:12:17]

Updated CL description.

kwiberg, could you review voice_engine/?
danil, could you review rtp_rtcp/?

[terelius, 2017-08-18 11:14:00]

terelius@webrtc.org changed reviewers:
+ stefan@webrtc.org

[terelius, 2017-08-18 11:14:01]

stefan, could you review call/?

[danilchap, 2017-08-18 11:34:03]

rtp_rtcp/ lgtm

https://codereview.webrtc.org/2997973002/diff/1/webrtc/logging/rtc_event_log/...
File webrtc/logging/rtc_event_log/rtc_event_log.h (left):

https://codereview.webrtc.org/2997973002/diff/1/webrtc/logging/rtc_event_log/...
webrtc/logging/rtc_event_log/rtc_event_log.h:128: virtual void
LogRtpHeader(PacketDirection direction,
can you keep old signature (as deprecated) to avoid breaking downstream projects

[terelius, 2017-08-21 14:42:39]

terelius@webrtc.org changed reviewers:
+ solenberg@webrtc.org
- kwiberg@webrtc.org, stefan@webrtc.org

[terelius, 2017-08-21 14:42:39]

danil, I added back an empty implementation in the interface. Does this seem
good enough?

solenberg, could you review the change in call/ and voice_engine/?

[terelius, 2017-08-21 15:11:56]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 15:12:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2017-08-21 15:17:09]

On 2017/08/21 14:42:39, terelius wrote:
> danil, I added back an empty implementation in the interface. Does this seem
> good enough?

Yes, lgtm

[commit-bot: I haz the power, 2017-08-21 17:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 17:10:28]

Dry run: This issue passed the CQ dry run.

[the sun, 2017-08-22 11:44:31]

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/call/call.cc
File webrtc/call/call.cc (left):

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/call/call.cc#oldco...
webrtc/call/call.cc:1292: event_log_->LogRtcpPacket(kIncomingPacket, packet,
length);
Can you remove the PacketDirection enum?

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h (right):

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h:45: void(const uint8_t*
header, size_t packet_length));
Please use ArrayView instead of pointer+size pairs.

[terelius, 2017-08-30 17:53:03]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-30 17:53:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-30 18:01:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-30 18:01:26]

Dry run: Try jobs failed on following builders:
  linux32_arm_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux32_arm_rel/builds/...)

[terelius, 2017-09-01 14:41:01]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-01 14:41:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-09-01 14:49:40]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-01 14:49:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-01 14:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-01 14:53:17]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24621)

[terelius, 2017-09-01 15:49:06]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-01 15:49:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-01 16:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-01 16:36:41]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/25650)

[terelius, 2017-09-04 12:47:51]

There have been large changes since the last iteration. Could you all take
another look?

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/call/call.cc
File webrtc/call/call.cc (left):

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/call/call.cc#oldco...
webrtc/call/call.cc:1292: event_log_->LogRtcpPacket(kIncomingPacket, packet,
length);
On 2017/08/22 11:44:31, the sun wrote:
> Can you remove the PacketDirection enum?

Not yet, since there apparently are downstream dependencies.

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h (right):

https://codereview.webrtc.org/2997973002/diff/40001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h:45: void(const uint8_t*
header, size_t packet_length));
On 2017/08/22 11:44:31, the sun wrote:
> Please use ArrayView instead of pointer+size pairs. 

After some discussions, it turned out that ArrayView is not the correct
representation for incoming and outgoing RTP packets. We want to avoid
repeatedly parsing the header, and the call sites actually hold parsed RTP
packets. I changed the functions to take RtpPacketToSend and RtpPacketReceived
instead.

This, however forces us to update the unit test since the incoming and outgoing
packets now are different types. The unit test used a fixed alternating sequence
of incoming and outgoing packets, which hard to extend the test with new event
types. I changed the test so that it randomly picks an event instead.

During this, I also ran into a problem where the test was spamming warnings
about the values of extension ids. When the test was originally written, the
extension IDs could be chosen randomly. Now, the ID is expected to be between 1
and 14. I changed the unit test so that it uses HeaderExtensionMap where the
extension ID's are mapped the same way as in e.g. rtp_packet_unittest.cc to
avoid the spam.

Changing the RTCP functions to ArrayView was straightforward.

[danilchap, 2017-09-05 08:47:16]

lgtm with few suggestions

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/call/call.cc#newc...
webrtc/call/call.cc:1303: rtc::ArrayView<const uint8_t>(packet, length));
for this use case there is 
rtc::MakeArrayView(packet, length)
(i.e. with template paramter deduction)

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.h:20: #include
"webrtc/rtc_base/array_view.h"
just moved to webrtc/api/

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:336:
log_dumper->LogIncomingRtcpPacket(rtc::ArrayView<const uint8_t>(
suggestion:
log_dumper->LogIncomingRtcpPacket(incoming_rtcp_packets[--remaining_incoming_rtcp]);

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:569: rtc::ArrayView<const
uint8_t>(rtcp_packet.data(), rtcp_packet.size()));
rtc::Buffer is implicitly convertable to rtc::ArrayView, so you should be able
to write just
log_dumper->LogOutgoingRtcpPacket(rtcp_packet);

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc:378: EXPECT_EQ(0,
std::memcmp(expected_packet.data(), parsed_header, header_size));
if you want detailed (with byte arrays printed) error message should it failed,
you may use
EXPACT_THAT(testing::make_tuple(expected_packet.data(), header_size),
testing::ElementsAreArray(parsed_header, parsed_header_size));

instead of this and ASSERT_EQ just above.

[eladalon, 2017-09-05 11:57:01]

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.cc:447:
LogRtcpPacket(kIncomingPacket, packet.data(), packet.size());
nit: Would it be possible to change PacketDirection into an enum-class? Then we
can s/kIncomingPacket/PacketDirection::Incoming.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:227: void
LogSessionAndReadBack(size_t incoming_rtp_count,
IMHO, it would be good to break this function down, since it's too big. I would
suggest having separate functions for randomly generating a session, for writing
it to a file and for reading it back from a file. (State would have to be kept
in between, but everything would be clearer, I think.)

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:487:
LogSessionAndReadBack(3,           // Number of incoming RTP packets.
One hack you could employ would be to define enums - NumberOfOutgoingRtpPackets,
NumberOfIngoingRtpPackets, etc. - and have the function accept them. This way
you get self-documentation that can't become outdates, as a comment would be if
things get shifted around. I am not sure if this would be overkill, though, or
purely against the coding style.

[terelius, 2017-09-07 12:43:22]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 12:43:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-07 12:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 12:45:27]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/29060)

[terelius, 2017-09-07 12:53:01]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 12:53:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-09-07 12:53:56]

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/call/call.cc#newc...
webrtc/call/call.cc:1303: rtc::ArrayView<const uint8_t>(packet, length));
On 2017/09/05 08:47:16, danilchap wrote:
> for this use case there is 
> rtc::MakeArrayView(packet, length)
> (i.e. with template paramter deduction)

Done.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.cc:447:
LogRtcpPacket(kIncomingPacket, packet.data(), packet.size());
On 2017/09/05 11:57:01, eladalon wrote:
> nit: Would it be possible to change PacketDirection into an enum-class? Then
we
> can s/kIncomingPacket/PacketDirection::Incoming.

The PacketDirection will be removed in a future CL. I don't think it is worth
changing at this point.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.h:20: #include
"webrtc/rtc_base/array_view.h"
On 2017/09/05 08:47:16, danilchap wrote:
> just moved to webrtc/api/

Done.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:227: void
LogSessionAndReadBack(size_t incoming_rtp_count,
On 2017/09/05 11:57:01, eladalon wrote:
> IMHO, it would be good to break this function down, since it's too big. I
would
> suggest having separate functions for randomly generating a session, for
writing
> it to a file and for reading it back from a file. (State would have to be kept
> in between, but everything would be clearer, I think.)

Done. Created a class SessionDescription that keeps the actual events and the
order they are written. Split this function into one for generation, one for
writing and one for reading/verifying. Added back functions (equivalent to)
PrintActualEvents and PrintExpectedEvents as discussed offline.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:336:
log_dumper->LogIncomingRtcpPacket(rtc::ArrayView<const uint8_t>(
On 2017/09/05 08:47:16, danilchap wrote:
> suggestion:
>
log_dumper->LogIncomingRtcpPacket(incoming_rtcp_packets[--remaining_incoming_rtcp]);

Done.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:487:
LogSessionAndReadBack(3,           // Number of incoming RTP packets.
On 2017/09/05 11:57:01, eladalon wrote:
> One hack you could employ would be to define enums -
NumberOfOutgoingRtpPackets,
> NumberOfIngoingRtpPackets, etc. - and have the function accept them. This way
> you get self-documentation that can't become outdates, as a comment would be
if
> things get shifted around. I am not sure if this would be overkill, though, or
> purely against the coding style.

Seems like overkill imo.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:569: rtc::ArrayView<const
uint8_t>(rtcp_packet.data(), rtcp_packet.size()));
On 2017/09/05 08:47:16, danilchap wrote:
> rtc::Buffer is implicitly convertable to rtc::ArrayView, so you should be able
> to write just
> log_dumper->LogOutgoingRtcpPacket(rtcp_packet);

Done.

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc (right):

https://codereview.webrtc.org/2997973002/diff/120001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc:378: EXPECT_EQ(0,
std::memcmp(expected_packet.data(), parsed_header, header_size));
On 2017/09/05 08:47:16, danilchap wrote:
> if you want detailed (with byte arrays printed) error message should it
failed,
> you may use
> EXPACT_THAT(testing::make_tuple(expected_packet.data(), header_size),
> testing::ElementsAreArray(parsed_header, parsed_header_size));
> 
> instead of this and ASSERT_EQ just above.

Done. Also changed the similar comparison above.

[commit-bot: I haz the power, 2017-09-07 12:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 12:58:09]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24782)

[terelius, 2017-09-07 12:59:54]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 13:00:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[eladalon, 2017-09-07 13:41:28]

https://codereview.webrtc.org/2997973002/diff/190001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/2997973002/diff/190001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:228: INCOMING_RTP = 1,
1. Assigning the numbers manually runs the risk of assigning the same value to
two different names.
2. Assigning beginning with 0 is preferable, as per another suggestion of mine.
3. I think it would be better to use CamelCase for the names as well. Otherwise,
you get CamelCase::UPPERCASE.

https://codereview.webrtc.org/2997973002/diff/190001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:551: void
SessionDescription::PrintExpectedEvents() {
It would probably be better to make the function accept an std::ostream, rather
than assume stdout is intended?

https://codereview.webrtc.org/2997973002/diff/190001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:552: for (size_t i = 0; i
< event_types.size(); i++) {
I think it would be safer to create a map of the enum-class's values to strings
of their name, because that way you could static_assert the number of
EventType-s and the number of their names is the same, making it less likely
someone would edit one without editing the other. (Also, because the map refers
to the enum-class's values by name, you can't rename them in one place without
getting a compilation error right next to the string, which would remind you to
edit it, too.)

https://codereview.webrtc.org/2997973002/diff/190001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:707: 2 +
extension_selection,  // Number of incoming RTP packets.
You could perhaps make GenerateSessionDescription() accept a vector, where the
indices correspond to EventType-s. Then:
vector<size_t> ook(EventType::Count, 0);
ook[EventType::IncomingRtp] = 3;
ook[EventType::OutgoingRtp] = 94;
GenerateSessionDescription(ook);

This would probably be more self-documenting and less brittle, IMHO.

[eladalon, 2017-09-07 13:42:18]

P.S: re-lgtm whether you accept my suggestions or not. If you could land this
as-is earlier, and only changes these things later, you'd unblock me faster.

[commit-bot: I haz the power, 2017-09-07 14:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 14:05:36]

Dry run: Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/22211)

[terelius, 2017-09-08 15:34:00]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-08 15:34:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-08 15:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-08 15:55:12]

Dry run: Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[terelius, 2017-09-11 10:29:51]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2017-09-11 10:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
danilchap@webrtc.org, eladalon@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2997973002/#ps350001 (title:
"Silly test5")

[terelius, 2017-09-11 10:29:52]

The CQ bit was unchecked by terelius@webrtc.org

[commit-bot: I haz the power, 2017-09-11 10:29:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-09-25 13:17:02]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-25 13:17:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-25 13:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-25 13:20:40]

Dry run: Try jobs failed on following builders:
  linux32_arm_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux32_arm_rel/builds/...)
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/...)
  linux_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/build...)

[terelius, 2017-09-25 17:06:56]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-25 17:08:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-25 17:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-25 17:36:20]

Dry run: Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/12817)