Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.

webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 23 matching lines @@
 
   MOCK_METHOD1(LogVideoSendStreamConfig,
                void(const rtclog::StreamConfig& config));
 
   MOCK_METHOD1(LogAudioReceiveStreamConfig,
                void(const rtclog::StreamConfig& config));
 
   MOCK_METHOD1(LogAudioSendStreamConfig,
                void(const rtclog::StreamConfig& config));
 
-  MOCK_METHOD3(LogRtpHeader,
-               void(PacketDirection direction,
-                    const uint8_t* header,
-                    size_t packet_length));
+  MOCK_METHOD2(LogIncomingRtpHeader,
+               void(const uint8_t* header, size_t packet_length));

[the sun, 2017/08/22 11:44:31]

Please use ArrayView instead of pointer+size pairs. 

[terelius, 2017/09/04 12:47:51]

After some discussions, it turned out that ArrayView is not the correct
representation for incoming and outgoing RTP packets. We want to avoid
repeatedly parsing the header, and the call sites actually hold parsed RTP
packets. I changed the functions to take RtpPacketToSend and RtpPacketReceived
instead.

This, however forces us to update the unit test since the incoming and outgoing
packets now are different types. The unit test used a fixed alternating sequence
of incoming and outgoing packets, which hard to extend the test with new event
types. I changed the test so that it randomly picks an event instead.

During this, I also ran into a problem where the test was spamming warnings
about the values of extension ids. When the test was originally written, the
extension IDs could be chosen randomly. Now, the ID is expected to be between 1
and 14. I changed the unit test so that it uses HeaderExtensionMap where the
extension ID's are mapped the same way as in e.g. rtp_packet_unittest.cc to
avoid the spam.

Changing the RTCP functions to ArrayView was straightforward.

 
-  MOCK_METHOD4(LogRtpHeader,
-               void(PacketDirection direction,
-                    const uint8_t* header,
+  MOCK_METHOD3(LogOutgoingRtpHeader,
+               void(const uint8_t* header,
                     size_t packet_length,
                     int probe_cluster_id));
 
-  MOCK_METHOD3(LogRtcpPacket,
-               void(PacketDirection direction,
-                    const uint8_t* packet,
-                    size_t length));
+  MOCK_METHOD2(LogIncomingRtcpPacket,
+               void(const uint8_t* packet, size_t length));
+
+  MOCK_METHOD2(LogOutgoingRtcpPacket,
+               void(const uint8_t* packet, size_t length));
 
   MOCK_METHOD1(LogAudioPlayout, void(uint32_t ssrc));
 
   MOCK_METHOD3(LogLossBasedBweUpdate,
                void(int32_t bitrate_bps,
                     uint8_t fraction_loss,
                     int32_t total_packets));
 
   MOCK_METHOD2(LogDelayBasedBweUpdate,
                void(int32_t bitrate_bps, BandwidthUsage detector_state));
 
   MOCK_METHOD1(LogAudioNetworkAdaptation,
                void(const AudioEncoderRuntimeConfig& config));
 
   MOCK_METHOD4(LogProbeClusterCreated,
                void(int id, int bitrate_bps, int min_probes, int min_bytes));
 
   MOCK_METHOD2(LogProbeResultSuccess, void(int id, int bitrate_bps));
   MOCK_METHOD2(LogProbeResultFailure,
                void(int id, ProbeFailureReason failure_reason));
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_LOGGING_RTC_EVENT_LOG_MOCK_MOCK_RTC_EVENT_LOG_H_