modules/rtp_rtcp/source/rtp_sender.cc - Issue 2997973002: Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: modules/rtp_rtcp/source/rtp_sender.cc

Issue 2997973002: Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.

Patch Set: Split VerifyRtpEvent into one incoming and one outgoing version. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: modules/rtp_rtcp/source/rtp_sender.cc

diff --git a/modules/rtp_rtcp/source/rtp_sender.cc b/modules/rtp_rtcp/source/rtp_sender.cc

index de9bf73c67f09462827785c9e808feb66582dfa2..8feea2a760ca51db72ccb8fb25c9a35fcdc850c6 100644

--- a/modules/rtp_rtcp/source/rtp_sender.cc

+++ b/modules/rtp_rtcp/source/rtp_sender.cc

@@ -642,8 +642,7 @@ bool RTPSender::SendPacketToNetwork(const RtpPacketToSend& packet,

? static_cast<int>(packet.size())

: -1;

if (event_log_ && bytes_sent > 0) {

- event_log_->LogRtpHeader(kOutgoingPacket, packet.data(), packet.size(),

- pacing_info.probe_cluster_id);

+ event_log_->LogOutgoingRtpHeader(packet, pacing_info.probe_cluster_id);

}

TRACE_EVENT_INSTANT2(TRACE_DISABLED_BY_DEFAULT("webrtc_rtp"),