Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: voice_engine/channel.cc

Issue 2997973002: Split LogRtpHeader and LogRtcpPacket into separate versions for incoming and outgoing packets.
Patch Set: Split VerifyRtpEvent into one incoming and one outgoing version. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « modules/rtp_rtcp/source/rtp_sender_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: voice_engine/channel.cc
diff --git a/voice_engine/channel.cc b/voice_engine/channel.cc
index aaca65a36dd65a63384d8e93e32c21af4fd1637d..c3a4e7b523e9903c818fd0d9b3b029debffec39c 100644
--- a/voice_engine/channel.cc
+++ b/voice_engine/channel.cc
@@ -11,7 +11,10 @@
#include "voice_engine/channel.h"
#include <algorithm>
+#include <map>
+#include <string>
#include <utility>
+#include <vector>
#include "api/array_view.h"
#include "audio/utility/audio_frame_operations.h"
@@ -98,29 +101,32 @@ class RtcEventLogProxy final : public webrtc::RtcEventLog {
}
}
- void LogRtpHeader(webrtc::PacketDirection direction,
- const uint8_t* header,
- size_t packet_length) override {
- LogRtpHeader(direction, header, packet_length, PacedPacketInfo::kNotAProbe);
+ void LogIncomingRtpHeader(const RtpPacketReceived& packet) override {
+ rtc::CritScope lock(&crit_);
+ if (event_log_) {
+ event_log_->LogIncomingRtpHeader(packet);
+ }
+ }
+
+ void LogOutgoingRtpHeader(const RtpPacketToSend& packet,
+ int probe_cluster_id) override {
+ rtc::CritScope lock(&crit_);
+ if (event_log_) {
+ event_log_->LogOutgoingRtpHeader(packet, probe_cluster_id);
+ }
}
- void LogRtpHeader(webrtc::PacketDirection direction,
- const uint8_t* header,
- size_t packet_length,
- int probe_cluster_id) override {
+ void LogIncomingRtcpPacket(rtc::ArrayView<const uint8_t> packet) override {
rtc::CritScope lock(&crit_);
if (event_log_) {
- event_log_->LogRtpHeader(direction, header, packet_length,
- probe_cluster_id);
+ event_log_->LogIncomingRtcpPacket(packet);
}
}
- void LogRtcpPacket(webrtc::PacketDirection direction,
- const uint8_t* packet,
- size_t length) override {
+ void LogOutgoingRtcpPacket(rtc::ArrayView<const uint8_t> packet) override {
rtc::CritScope lock(&crit_);
if (event_log_) {
- event_log_->LogRtcpPacket(direction, packet, length);
+ event_log_->LogOutgoingRtcpPacket(packet);
}
}
« no previous file with comments | « modules/rtp_rtcp/source/rtp_sender_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698