Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 2997713002: Reimplement the builtin audio codec factories using the new stuff in api/ (Closed)

Created:
3 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reimplement the builtin audio codec factories using the new stuff in api/ The whole point of all the audio codec stuff we've recently published in api/ is to function as lego bricks so that building stuff like our builtin audio codec factories will be easy. BUG=webrtc:7821, webrtc:7822 Review-Url: https://codereview.webrtc.org/2997713002 Cr-Commit-Position: refs/heads/master@{#19446} Committed: https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95905b469d5ede173

Patch Set 1 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -488 lines) Patch
M webrtc/api/audio_codecs/BUILD.gn View 2 chunks +76 lines, -2 lines 0 comments Download
M webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc View 1 chunk +60 lines, -2 lines 2 comments Download
M webrtc/api/audio_codecs/builtin_audio_encoder_factory.cc View 1 chunk +64 lines, -2 lines 0 comments Download
M webrtc/api/audio_codecs/opus/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +1 line, -29 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 1 chunk +0 lines, -257 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.cc View 1 chunk +0 lines, -144 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (23 generated)
kwiberg-webrtc
3 years, 4 months ago (2017-08-21 22:43:40 UTC) #21
ossu
Some of the bots seem to want a rebase, but other than that, this lgtm! ...
3 years, 4 months ago (2017-08-22 12:29:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997713002/60001
3 years, 4 months ago (2017-08-22 12:36:55 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95905b469d5ede173
3 years, 4 months ago (2017-08-22 12:39:27 UTC) #27
kwiberg-webrtc
And no, there's not actually a need to rebase (I've tried that multiple times, and ...
3 years, 4 months ago (2017-08-22 12:40:35 UTC) #28
sakal
3 years, 4 months ago (2017-08-22 15:11:17 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:60001) has been created in
https://codereview.webrtc.org/2996373002/ by sakal@webrtc.org.

The reason for reverting is: Speculatively reverting, likely breaks
chromium.webrtc.fyi.

Failed to create local offer: Test failed: Error: setSdpDefaultCodec() failed:
"Unknown ID for |codec| = 'G722'."

Failing bots:
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Mac%20Tes...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win8%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T....

Powered by Google App Engine
This is Rietveld 408576698