Reimplement the builtin audio codec factories using the new stuff in api/

Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

BUG=webrtc:7821, webrtc:7822
Review-Url: https://codereview.webrtc.org/2997713002
Cr-Commit-Position: refs/heads/master@{#19446}
Committed: https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95905b469d5ede173

[kwiberg-webrtc, 2017-08-10 12:18:46]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 12:18:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 12:21:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 12:21:22]

Dry run: Try jobs failed on following builders:
  linux32_arm_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux32_arm_rel/builds/...)
  linux_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/26949)
  linux_gcc_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gcc_rel/builds/1159)
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/22663)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/26884)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/28017)

[kwiberg-webrtc, 2017-08-10 12:40:49]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-10 12:41:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 12:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-10 12:49:56]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20013)

[kwiberg-webrtc, 2017-08-21 11:58:53]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 11:59:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 13:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 13:21:35]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-21 20:36:42]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 20:36:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 21:07:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 21:07:57]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-21 22:41:52]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2017-08-21 22:42:03]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2017-08-21 22:42:15]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2017-08-21 22:43:39]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2017-08-22 12:29:16]

Some of the bots seem to want a rebase, but other than that, this lgtm!

https://codereview.webrtc.org/2997713002/diff/60001/webrtc/api/audio_codecs/b...
File webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc (right):

https://codereview.webrtc.org/2997713002/diff/60001/webrtc/api/audio_codecs/b...
webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc:76: AudioDecoderG711,
NotAdvertised<AudioDecoderL16>>();
Neat!

Not advertising L16 in our builtin factory means it won't be used (unless
someone happens to know it's supported and manually mangles the SDP). We should
have a think about what to do about that, but for now we might as well retain
this hidden support for it.

[kwiberg-webrtc, 2017-08-22 12:36:44]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-08-22 12:36:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 12:39:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503405404304600,
"parent_rev": "413ee9a010eca70712a6935c68b815201bee1270", "commit_rev":
"417989a8643d0d19052a87e95905b469d5ede173"}

[commit-bot: I haz the power, 2017-08-22 12:39:26]

Description was changed from

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

BUG=webrtc:7821, webrtc:7822
==========

to

==========
Reimplement the builtin audio codec factories using the new stuff in api/

The whole point of all the audio codec stuff we've recently published
in api/ is to function as lego bricks so that building stuff like our
builtin audio codec factories will be easy.

BUG=webrtc:7821, webrtc:7822

Review-Url: https://codereview.webrtc.org/2997713002
Cr-Commit-Position: refs/heads/master@{#19446}
Committed:
https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95...
==========

[commit-bot: I haz the power, 2017-08-22 12:39:27]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95...

[kwiberg-webrtc, 2017-08-22 12:40:35]

And no, there's not actually a need to rebase (I've tried that multiple times,
and it doesn't help). It's just the Chromium bots that can't apply WebRTC
patches that remove files, IIUC.

https://codereview.webrtc.org/2997713002/diff/60001/webrtc/api/audio_codecs/b...
File webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc (right):

https://codereview.webrtc.org/2997713002/diff/60001/webrtc/api/audio_codecs/b...
webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc:76: AudioDecoderG711,
NotAdvertised<AudioDecoderL16>>();
On 2017/08/22 12:29:16, ossu wrote:
> Neat!
> 
> Not advertising L16 in our builtin factory means it won't be used (unless
> someone happens to know it's supported and manually mangles the SDP). We
should
> have a think about what to do about that, but for now we might as well retain
> this hidden support for it.

Yes, I realized that this behavior was probably originally a mistake, but I felt
that it was better to keep it even though it's now clearly visible in the code,
and possibly change it in a future CL.

(My tentative plan is in fact to get rid of the Builtin factories, and have all
WebRTC users explicitly list the codecs they want.)

[sakal, 2017-08-22 15:11:17]

A revert of this CL (patchset #1 id:60001) has been created in
https://codereview.webrtc.org/2996373002/ by sakal@webrtc.org.

The reason for reverting is: Speculatively reverting, likely breaks
chromium.webrtc.fyi.

Failed to create local offer: Test failed: Error: setSdpDefaultCodec() failed:
"Unknown ID for |codec| = 'G722'."

Failing bots:
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Mac%20Tes...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win8%20Te...
https://uberchromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win10%20T....