Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 3003603002: Remove dead code (Closed)

Created:
3 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 3 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead code This code became dead when the builtin audio codec factories were rewritten in https://codereview.webrtc.org/2997713002/. BUG=webrtc:7821, webrtc:7822 Review-Url: https://codereview.webrtc.org/3003603002 Cr-Commit-Position: refs/heads/master@{#19535} Committed: https://chromium.googlesource.com/external/webrtc/+/d1d79f6866fcde94bb0354cec7d6ecaaf72de235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -260 lines) Patch
M webrtc/api/audio_codecs/g722/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/audio_codecs/g722/audio_encoder_g722.cc View 1 chunk +20 lines, -1 line 0 comments Download
M webrtc/api/audio_codecs/ilbc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/audio_codecs/ilbc/audio_encoder_ilbc.cc View 2 chunks +19 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc View 4 chunks +0 lines, -48 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc View 3 chunks +0 lines, -40 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc View 3 chunks +0 lines, -40 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 3 chunks +0 lines, -52 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.cc View 4 chunks +1 line, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
kwiberg-webrtc
3 years, 4 months ago (2017-08-21 23:50:13 UTC) #6
ossu
This is great! Now all we need to do is get rid of CodecInst and ...
3 years, 4 months ago (2017-08-22 13:00:12 UTC) #7
ossu
On 2017/08/22 13:00:12, ossu wrote: > This is great! Now all we need to do ...
3 years, 4 months ago (2017-08-22 13:00:43 UTC) #8
hlundin-webrtc
On 2017/08/22 13:00:43, ossu wrote: > On 2017/08/22 13:00:12, ossu wrote: > > This is ...
3 years, 4 months ago (2017-08-23 09:39:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003603002/1
3 years, 3 months ago (2017-08-26 04:54:30 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-08-26 05:22:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d1d79f6866fcde94bb0354cec...

Powered by Google App Engine
This is Rietveld 408576698