Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2996373002: Revert of Reimplement the builtin audio codec factories using the new stuff in api/ (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
ossu, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reimplement the builtin audio codec factories using the new stuff in api/ (patchset #1 id:60001 of https://codereview.webrtc.org/2997713002/ ) Reason for revert: Speculatively reverting, likely breaks chromium.webrtc.fyi. Failed to create local offer: Test failed: Error: setSdpDefaultCodec() failed: "Unknown ID for |codec| = 'G722'." Failing bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/42349 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/builds/1561 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/8517 Original issue's description: > Reimplement the builtin audio codec factories using the new stuff in api/ > > The whole point of all the audio codec stuff we've recently published > in api/ is to function as lego bricks so that building stuff like our > builtin audio codec factories will be easy. > > BUG=webrtc:7821, webrtc:7822 > > Review-Url: https://codereview.webrtc.org/2997713002 > Cr-Commit-Position: refs/heads/master@{#19446} > Committed: https://chromium.googlesource.com/external/webrtc/+/417989a8643d0d19052a87e95905b469d5ede173 TBR=ossu@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7821, webrtc:7822 Review-Url: https://codereview.webrtc.org/2996373002 Cr-Commit-Position: refs/heads/master@{#19452} Committed: https://chromium.googlesource.com/external/webrtc/+/bcc655c2c71bb1df2ef94cdbf126b318135f1920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -205 lines) Patch
M webrtc/api/audio_codecs/BUILD.gn View 2 chunks +2 lines, -76 lines 0 comments Download
M webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc View 1 chunk +2 lines, -60 lines 0 comments Download
M webrtc/api/audio_codecs/builtin_audio_encoder_factory.cc View 1 chunk +2 lines, -64 lines 0 comments Download
M webrtc/api/audio_codecs/opus/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +29 lines, -1 line 0 comments Download
A webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.h View 1 chunk +24 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 1 chunk +257 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.h View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.cc View 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
sakal
Created Revert of Reimplement the builtin audio codec factories using the new stuff in api/
3 years, 4 months ago (2017-08-22 15:11:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996373002/1
3 years, 4 months ago (2017-08-22 15:13:31 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 15:13:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bcc655c2c71bb1df2ef94cdbf...

Powered by Google App Engine
This is Rietveld 408576698