ObjC: Fix quality scaling for injected encoders

ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

Note that the ObjC interface for scalingSettings is slightly different from the C++
interface in that we require explicit QP thresholds to turn quality scaling on, i.e.
we don't provide default values. I think this is more modular as we want to move
codec specific knowledge out from the WebRTC core. I would like to update the
C++ webrtc::VideoEncoder interface to do the same in another CL.

BUG=webrtc:7924
Review-Url: https://codereview.webrtc.org/2991123002
Cr-Commit-Position: refs/heads/master@{#19202}
Committed: https://chromium.googlesource.com/external/webrtc/+/5dfac33dfdd430d60f3ecf4c59d15a62ec1f68ef

[magjed_webrtc, 2017-08-01 11:54:07]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-01 11:54:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-08-01 11:56:15]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2017-08-01 12:01:18]

Description was changed from

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

BUG=webrtc:7924
==========

to

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

BUG=webrtc:7924
==========

[magjed_webrtc, 2017-08-01 12:01:18]

magjed@webrtc.org changed reviewers:
+ andersc@webrtc.org, denicija@webrtc.org, tkchin@webrtc.org

[magjed_webrtc, 2017-08-01 12:01:28]

Please take a look.

[magjed_webrtc, 2017-08-01 12:08:41]

Description was changed from

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

BUG=webrtc:7924
==========

to

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

Note that the ObjC interface for scalingSettings is slightly different from the
C++
interface in that we require explicit QP thresholds to turn quality scaling on,
i.e.
we don't provide default values. I think this is more modular as we want to move
codec specific knowledge out from the WebRTC core. I would like to update the
C++ webrtc::VideoEncoder interface to do the same in another CL.

BUG=webrtc:7924
==========

[commit-bot: I haz the power, 2017-08-01 12:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-01 12:17:46]

Dry run: This issue passed the CQ dry run.

[daniela-webrtc, 2017-08-01 13:09:48]

lgtm

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
(right):

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm:118:
ScalingSettings(false /* enabled */);
I guess this means /* disabled */ ?

[andersc, 2017-08-01 14:30:26]

lgtm

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h (right):

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:137: // TODO(andersc):
Add implementationName method.
Is this related? I suppose it's a oneliner just returning a string (to
differentiate between implementations of the same codec?)?

[magjed_webrtc, 2017-08-01 15:04:55]

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
(right):

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm:118:
ScalingSettings(false /* enabled */);
On 2017/08/01 13:09:48, daniela-webrtc wrote:
> I guess this means /* disabled */ ?

The comment represents the argument name, so it represents enabled==false, i.e.
disabled.

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h (right):

https://codereview.webrtc.org/2991123002/diff/20001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:137: // TODO(andersc):
Add implementationName method.
On 2017/08/01 14:30:26, andersc wrote:
> Is this related? I suppose it's a oneliner just returning a string (to
> differentiate between implementations of the same codec?)?

It's not really related but it's another function that we haven't wrapped, I
just wanted to add a TODO so we don't forget about it. It should be easy to
implement, yes.

[magjed_webrtc, 2017-08-01 15:05:06]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-08-01 15:05:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-01 15:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501599906670190,
"parent_rev": "822ff2b794eb676541ef3cc6d5c7bc7380a590cc", "commit_rev":
"5dfac33dfdd430d60f3ecf4c59d15a62ec1f68ef"}

[commit-bot: I haz the power, 2017-08-01 15:08:06]

Description was changed from

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

Note that the ObjC interface for scalingSettings is slightly different from the
C++
interface in that we require explicit QP thresholds to turn quality scaling on,
i.e.
we don't provide default values. I think this is more modular as we want to move
codec specific knowledge out from the WebRTC core. I would like to update the
C++ webrtc::VideoEncoder interface to do the same in another CL.

BUG=webrtc:7924
==========

to

==========
ObjC: Fix quality scaling for injected encoders

We missed to implement quality scaling in the original CL
https://codereview.webrtc.org/2977213002/. This CL implements it.

Note that the ObjC interface for scalingSettings is slightly different from the
C++
interface in that we require explicit QP thresholds to turn quality scaling on,
i.e.
we don't provide default values. I think this is more modular as we want to move
codec specific knowledge out from the WebRTC core. I would like to update the
C++ webrtc::VideoEncoder interface to do the same in another CL.

BUG=webrtc:7924

Review-Url: https://codereview.webrtc.org/2991123002
Cr-Commit-Position: refs/heads/master@{#19202}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5dfac33dfdd430d60f3ecf4c5...
==========

[commit-bot: I haz the power, 2017-08-01 15:08:07]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5dfac33dfdd430d60f3ecf4c5...