Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

Issue 2991123002: ObjC: Fix quality scaling for injected encoders (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
index c464dabd79bb72e8832bc9913d0976941bddea46..0472fc07ae2a8939430801efe0a5ba8beee1af01 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
@@ -111,6 +111,13 @@ class ObjCVideoEncoder : public VideoEncoder {
bool SupportsNativeHandle() const { return true; }
+ VideoEncoder::ScalingSettings GetScalingSettings() const {
+ RTCVideoEncoderQpThresholds* qp_thresholds = [encoder_ scalingSettings];
+ return qp_thresholds ?
+ ScalingSettings(true /* enabled */, qp_thresholds.low, qp_thresholds.high) :
+ ScalingSettings(false /* enabled */);
daniela-webrtc 2017/08/01 13:09:48 I guess this means /* disabled */ ?
magjed_webrtc 2017/08/01 15:04:55 The comment represents the argument name, so it re
+ }
+
private:
id<RTCVideoEncoder> encoder_;
};

Powered by Google App Engine
This is Rietveld 408576698