webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm - Issue 2991123002: ObjC: Fix quality scaling for injected encoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

Issue 2991123002: ObjC: Fix quality scaling for injected encoders (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

index d3f5ef9a93300eb5ad6b722e0e71c54adf95614b..2e87458fe83cb0675b1d7a6de5dab19a3d5080a4 100644

--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

@@ -757,6 +757,8 @@ void H264VideoToolboxEncoder::OnEncodedFrame(

bitrate_adjuster_.Update(frame._length);

}

+// TODO(magjed): This function is not used by RTCVideoEncoderH264, but this whole file will be

+// removed soon and inlined as ObjC.

VideoEncoder::ScalingSettings H264VideoToolboxEncoder::GetScalingSettings()

const {

return VideoEncoder::ScalingSettings(true, internal::kLowH264QpThreshold,