ObjC: Fix quality scaling for injected encoders

webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 86 matching lines @@
 @property(nonatomic, assign) unsigned int maxBitrate;
 @property(nonatomic, assign) unsigned int minBitrate;
 @property(nonatomic, assign) unsigned int targetBitrate;
 
 @property(nonatomic, assign) uint32_t maxFramerate;
 
 @property(nonatomic, assign) unsigned int qpMax;
 
 @end
 
+/** QP thresholds for encoder. Corresponds to webrtc::VideoEncoder::QpThresholds. */
+RTC_EXPORT
+@interface RTCVideoEncoderQpThresholds : NSObject
+
+- (instancetype)initWithThresholdsLow:(NSInteger)low high:(NSInteger)high;
+
+@property(nonatomic, readonly) NSInteger low;
+@property(nonatomic, readonly) NSInteger high;
+
+@end
+
 /** Protocol for encoder implementations. */
 RTC_EXPORT
 @protocol RTCVideoEncoder <NSObject>
 
 - (void)setCallback:(RTCVideoEncoderCallback)callback;
 - (NSInteger)startEncodeWithSettings:(RTCVideoEncoderSettings *)settings
                        numberOfCores:(int)numberOfCores;
 - (NSInteger)releaseEncoder;
 - (void)destroy;
 - (NSInteger)encode:(RTCVideoFrame *)frame
     codecSpecificInfo:(id<RTCCodecSpecificInfo>)info
            frameTypes:(NSArray<NSNumber *> *)frameTypes;
 - (BOOL)setBitrate:(uint32_t)bitrateKbit framerate:(uint32_t)framerate;
 
+/** Returns QP scaling settings for encoder. The quality scaler adjusts the resolution in order to
+ *  keep the QP from the encoded images within the given range. Returning nil from this function
+ *  disables quality scaling. */
+- (RTCVideoEncoderQpThresholds *)scalingSettings;
+
+// TODO(andersc): Add implementationName method.

[andersc, 2017/08/01 14:30:26]

Is this related? I suppose it's a oneliner just returning a string (to
differentiate between implementations of the same codec?)?

[magjed_webrtc, 2017/08/01 15:04:55]

It's not really related but it's another function that we haven't wrapped, I
just wanted to add a TODO so we don't forget about it. It should be easy to
implement, yes.

+
 @end
 
 /** Protocol for decoder implementations. */
 RTC_EXPORT
 @protocol RTCVideoDecoder <NSObject>
 
 - (void)setCallback:(RTCVideoDecoderCallback)callback;
 - (NSInteger)startDecodeWithSettings:(RTCVideoEncoderSettings *)settings
                        numberOfCores:(int)numberOfCores;
 - (NSInteger)releaseDecoder;
 - (void)destroy;
 - (NSInteger)decode:(RTCEncodedImage *)encodedImage
           missingFrames:(BOOL)missingFrames
     fragmentationHeader:(RTCRtpFragmentationHeader *)fragmentationHeader
       codecSpecificInfo:(__nullable id<RTCCodecSpecificInfo>)info
            renderTimeMs:(int64_t)renderTimeMs;
 
+// TODO(andersc): Add implementationName method.
+
 @end
 
 NS_ASSUME_NONNULL_END