Decoupling rtc_base_approved from Obj-C code

Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
NOTRY=True

Review-Url: https://codereview.webrtc.org/2988433002
Cr-Commit-Position: refs/heads/master@{#19767}
Committed: https://chromium.googlesource.com/external/webrtc/+/bc378479787930b511b151b278318516492bc9fc

[mbonadei, 2017-07-26 07:19:58]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org, kthelgason@webrtc.org

[kjellander_webrtc, 2017-07-26 20:07:15]

lgtm

[kthelgason, 2017-08-03 17:42:34]

lgtm

[mbonadei, 2017-08-16 07:58:13]

Description was changed from

==========
Decoupling rtc_base_approved from apple specific code [with cyclic deps]

BUG=webrtc:7743
==========

to

==========
Decoupling rtc_base_approved from Obj-C code.

BUG=webrtc:7743
==========

[mbonadei, 2017-08-16 14:16:58]

Description was changed from

==========
Decoupling rtc_base_approved from Obj-C code.

BUG=webrtc:7743
==========

to

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
==========

[mbonadei, 2017-08-31 14:21:27]

Description was changed from

==========
The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
==========

to

==========
Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
==========

[mbonadei, 2017-08-31 14:21:27]

mbonadei@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[mbonadei, 2017-08-31 14:21:42]

+kwiberg@ for OWNER lgtm.

[kwiberg-webrtc, 2017-08-31 20:57:03]

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn
File webrtc/rtc_base/BUILD.gn (right):

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:83: rtc_static_library("rtc_base_approved") {
If you make this a source set, can you drop the no-op file?

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:94: ]
Can you make this public_dep unconditional, and turn the public_dep on line 313
into a regular dep? It's annoying to see what exports what already with one
layer of public_deps, and I'll be two layers are worse...

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:103: visibility = [ ":*" ]
Could you tighten the visibility restrictions here, and the two below on lines
303 and 308? In your other CL, you had very strict visibility limits, and that
made it easy to see who was supposed to be depending on what.

[mbonadei, 2017-09-01 09:46:38]

PTAL.

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn
File webrtc/rtc_base/BUILD.gn (right):

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:83: rtc_static_library("rtc_base_approved") {
On 2017/08/31 20:57:02, kwiberg-webrtc wrote:
> If you make this a source set, can you drop the no-op file?

Yes, done.

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:94: ]
On 2017/08/31 20:57:02, kwiberg-webrtc wrote:
> Can you make this public_dep unconditional, and turn the public_dep on line
313
> into a regular dep? It's annoying to see what exports what already with one
> layer of public_deps, and I'll be two layers are worse...

Done.

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:103: visibility = [ ":*" ]
On 2017/08/31 20:57:03, kwiberg-webrtc wrote:
> Could you tighten the visibility restrictions here, and the two below on lines
> 303 and 308? In your other CL, you had very strict visibility limits, and that
> made it easy to see who was supposed to be depending on what.

Yes, I remember I talked about this with kjellander@ and we decided to use ":*"
(but I don't remember why) so probably we have to change the other CL.

Henrik: do you remember why we prefer ":*"?

[kjellander_webrtc, 2017-09-01 10:11:20]

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn
File webrtc/rtc_base/BUILD.gn (right):

https://codereview.webrtc.org/2988433002/diff/60001/webrtc/rtc_base/BUILD.gn#...
webrtc/rtc_base/BUILD.gn:103: visibility = [ ":*" ]
On 2017/09/01 09:46:38, mbonadei wrote:
> On 2017/08/31 20:57:03, kwiberg-webrtc wrote:
> > Could you tighten the visibility restrictions here, and the two below on
lines
> > 303 and 308? In your other CL, you had very strict visibility limits, and
that
> > made it easy to see who was supposed to be depending on what.
> 
> Yes, I remember I talked about this with kjellander@ and we decided to use
":*"
> (but I don't remember why) so probably we have to change the other CL.
> 
> Henrik: do you remember why we prefer ":*"?

It's just laziness, I wouldn't say we prefer one or the other. You could just
list the targets explicitly instead, and the more I think of it the more I
prefer that.
:* is just a little easier since it allows everything in this file, which is
usually sufficient (but not as clear).

[mbonadei, 2017-09-01 11:55:23]

> It's just laziness, I wouldn't say we prefer one or the other. You could just
> list the targets explicitly instead, and the more I think of it the more I
> prefer that.
> :* is just a little easier since it allows everything in this file, which is
> usually sufficient (but not as clear).

It makes sense. I have listed targets explicitly.

PTAL.

[kwiberg-webrtc, 2017-09-01 12:31:05]

lgtm, provided you un-break the comment

https://codereview.webrtc.org/2988433002/diff/140001/webrtc/rtc_base/BUILD.gn
File webrtc/rtc_base/BUILD.gn (right):

https://codereview.webrtc.org/2988433002/diff/140001/webrtc/rtc_base/BUILD.gn...
webrtc/rtc_base/BUILD.gn:96: #   :rtc_base_approved -> ../system_wrappers ->
:rtc_base_approved
This comment is supposed to apply to check_includes below.

[mbonadei, 2017-09-11 10:40:47]

Description was changed from

==========
Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
==========

to

==========
Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
NOTRY=True
==========

[mbonadei, 2017-09-11 10:40:57]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-09-11 10:40:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org, kjellander@webrtc.org, kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2988433002/#ps200001 (title:
"Rebasing again :)")

[commit-bot: I haz the power, 2017-09-11 10:41:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-11 10:43:35]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1505126457936640,
"parent_rev": "0677904e1b916594ab695a2282619cb3f207f03a", "commit_rev":
"bc378479787930b511b151b278318516492bc9fc"}

[commit-bot: I haz the power, 2017-09-11 10:43:41]

Description was changed from

==========
Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
NOTRY=True
==========

to

==========
Decoupling rtc_base_approved from Obj-C code

The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).

To achieve this we have created 2 targets (rtc_base_approved_objc and
rtc_base_approved_generic) and rtc_base_approved will act as a proxy between
these targets (this way we can avoid a circular dependency between
rtc_base_approved_generic and rtc_base_approved_objc).

BUG=webrtc:7743
NOTRY=True

Review-Url: https://codereview.webrtc.org/2988433002
Cr-Commit-Position: refs/heads/master@{#19767}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bc378479787930b511b151b27...
==========

[commit-bot: I haz the power, 2017-09-11 10:43:43]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/external/webrtc/+/bc378479787930b511b151b27...