Decoupling rtc_base_approved from Obj-C code

webrtc/rtc_base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 13 matching lines @@
     ":rtc_base_approved",
     ":rtc_task_queue",
     ":sequenced_task_checker",
     ":weak_ptr",
   ]
   if (is_android) {
     public_deps += [ ":base_java" ]
   }
 }
 
-config("rtc_base_approved_all_dependent_config") {
-  if (is_mac && !build_with_chromium) {
-    libs = [ "Foundation.framework" ]  # needed for logging_mac.mm
-  }
-}
-
 config("rtc_base_chromium_config") {
   defines = [ "NO_MAIN_THREAD_WRAPPING" ]
 }
 
 config("rtc_base_all_dependent_config") {
   if (is_ios) {
     libs = [
       "CFNetwork.framework",
       "Security.framework",
       "SystemConfiguration.framework",
@@ skipping 29 matching lines @@
     ]
   }
 }
 
 source_set("compile_assert_c") {
   sources = [
     "compile_assert_c.h",
   ]
 }
 
+rtc_static_library("rtc_base_approved") {

[kwiberg-webrtc, 2017/08/31 20:57:02]

If you make this a source set, can you drop the no-op file?

[mbonadei, 2017/09/01 09:46:38]

Yes, done.

+  sources = [
+    "noop.cc",
+  ]
+  if (is_mac && !build_with_chromium) {
+    public_deps = [
+      ":rtc_base_approved_objc",
+    ]
+  } else {
+    public_deps = [
+      ":rtc_base_approved_generic",
+    ]

[kwiberg-webrtc, 2017/08/31 20:57:02]

Can you make this public_dep unconditional, and turn the public_dep on line 313
into a regular dep? It's annoying to see what exports what already with one
layer of public_deps, and I'll be two layers are worse...

[mbonadei, 2017/09/01 09:46:38]

Done.

+  }
+}
+
 # The subset of rtc_base approved for use outside of libjingle.
-rtc_static_library("rtc_base_approved") {
+rtc_static_library("rtc_base_approved_generic") {
   # TODO(kjellander): Remove (bugs.webrtc.org/7480)
   # Enabling GN check triggers a cyclic dependency caused by rate_limiter.cc:
   #   :rtc_base_approved -> ../system_wrappers -> :rtc_base_approved
+  visibility = [ ":*" ]

[kwiberg-webrtc, 2017/08/31 20:57:03]

Could you tighten the visibility restrictions here, and the two below on lines
303 and 308? In your other CL, you had very strict visibility limits, and that
made it easy to see who was supposed to be depending on what.

[mbonadei, 2017/09/01 09:46:38]

Yes, I remember I talked about this with kjellander@ and we decided to use ":*"
(but I don't remember why) so probably we have to change the other CL.

Henrik: do you remember why we prefer ":*"?

[kjellander_webrtc, 2017/09/01 10:11:20]

It's just laziness, I wouldn't say we prefer one or the other. You could just
list the targets explicitly instead, and the more I think of it the more I
prefer that.
:* is just a little easier since it allows everything in this file, which is
usually sufficient (but not as clear).

   check_includes = false
   defines = []
   libs = []
   deps = []
-  all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
 
   sources = [
     "array_view.h",
     "arraysize.h",
     "atomicops.h",
     "base64.cc",
     "base64.h",
     "basictypes.h",
     "bind.h",
     "bitbuffer.cc",
@@ skipping 94 matching lines @@
     # Dependency on chromium's logging (in //base).
     deps += [ "//base:base" ]
     sources += [
       "../../webrtc_overrides/webrtc/rtc_base/logging.cc",
       "../../webrtc_overrides/webrtc/rtc_base/logging.h",
     ]
   } else {
     sources += [
       "logging.cc",
       "logging.h",
-      "logging_mac.mm",
     ]
   }
   if (is_component_build && is_win) {
     # Copy the VS runtime DLLs into the isolate so that they don't have to be
     # preinstalled on the target machine. The debug runtimes have a "d" at
     # the end.
     # This is a copy of https://codereview.chromium.org/1783973002.
     # TODO(ehmaldonado): We'd like Chromium to make this changes easier to use,
     # so we don't have to copy their changes and risk breakages.
     # See http://crbug.com/653569
@@ skipping 59 matching lines @@
       } else {
         data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ]
       }
     }
   }
   if (is_nacl) {
     deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
   }
 }
 
+if (is_mac && !build_with_chromium) {
+  config("rtc_base_approved_objc_all_dependent_config") {
+    visibility = [ ":*" ]
+    libs = [ "Foundation.framework" ]  # needed for logging_mac.mm
+  }
+
+  rtc_static_library("rtc_base_approved_objc") {
+    visibility = [ ":*" ]
+    all_dependent_configs = [ ":rtc_base_approved_objc_all_dependent_config" ]
+    sources = [
+      "logging_mac.mm",
+    ]
+    public_deps = [
+      ":rtc_base_approved_generic",
+    ]
+  }
+}
+
 config("enable_libevent_config") {
   defines = [ "WEBRTC_BUILD_LIBEVENT" ]
 }
 
 rtc_static_library("rtc_task_queue") {
   public_deps = [
     ":rtc_base_approved",
   ]
 
   if (build_with_chromium) {
@@ skipping 728 matching lines @@
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/ContextUtils.java",
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }