Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: webrtc/rtc_base/BUILD.gn

Issue 2988433002: Decoupling rtc_base_approved from Obj-C code (Closed)
Patch Set: Rebasing again :) Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/crypto.gni") 9 import("//build/config/crypto.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 13 matching lines...) Expand all
24 ":rtc_base_approved", 24 ":rtc_base_approved",
25 ":rtc_task_queue", 25 ":rtc_task_queue",
26 ":sequenced_task_checker", 26 ":sequenced_task_checker",
27 ":weak_ptr", 27 ":weak_ptr",
28 ] 28 ]
29 if (is_android) { 29 if (is_android) {
30 public_deps += [ ":base_java" ] 30 public_deps += [ ":base_java" ]
31 } 31 }
32 } 32 }
33 33
34 config("rtc_base_approved_all_dependent_config") {
35 if (is_mac && !build_with_chromium) {
36 libs = [ "Foundation.framework" ] # needed for logging_mac.mm
37 }
38 }
39
40 config("rtc_base_chromium_config") { 34 config("rtc_base_chromium_config") {
41 defines = [ "NO_MAIN_THREAD_WRAPPING" ] 35 defines = [ "NO_MAIN_THREAD_WRAPPING" ]
42 } 36 }
43 37
44 config("rtc_base_all_dependent_config") { 38 config("rtc_base_all_dependent_config") {
45 if (is_ios) { 39 if (is_ios) {
46 libs = [ 40 libs = [
47 "CFNetwork.framework", 41 "CFNetwork.framework",
48 "Security.framework", 42 "Security.framework",
49 "SystemConfiguration.framework", 43 "SystemConfiguration.framework",
(...skipping 29 matching lines...) Expand all
79 ] 73 ]
80 } 74 }
81 } 75 }
82 76
83 source_set("compile_assert_c") { 77 source_set("compile_assert_c") {
84 sources = [ 78 sources = [
85 "compile_assert_c.h", 79 "compile_assert_c.h",
86 ] 80 ]
87 } 81 }
88 82
83 rtc_source_set("rtc_base_approved") {
84 public_deps = [
85 ":rtc_base_approved_generic",
86 ]
87 if (is_mac && !build_with_chromium) {
88 public_deps += [ ":rtc_base_approved_objc" ]
89 }
90 }
91
89 # The subset of rtc_base approved for use outside of libjingle. 92 # The subset of rtc_base approved for use outside of libjingle.
90 rtc_static_library("rtc_base_approved") { 93 rtc_source_set("rtc_base_approved_generic") {
94 visibility = [
95 ":rtc_base_approved",
96 ":rtc_base_approved_objc",
97 ]
98
91 # TODO(kjellander): Remove (bugs.webrtc.org/7480) 99 # TODO(kjellander): Remove (bugs.webrtc.org/7480)
92 # Enabling GN check triggers a cyclic dependency caused by rate_limiter.cc: 100 # Enabling GN check triggers a cyclic dependency caused by rate_limiter.cc:
93 # :rtc_base_approved -> ../system_wrappers -> :rtc_base_approved 101 # :rtc_base_approved -> ../system_wrappers -> :rtc_base_approved
94 check_includes = false 102 check_includes = false
95 defines = [] 103 defines = []
96 libs = [] 104 libs = []
97 deps = [] 105 deps = []
98 all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
99 106
100 sources = [ 107 sources = [
101 "array_view.h", 108 "array_view.h",
102 "arraysize.h", 109 "arraysize.h",
103 "atomicops.h", 110 "atomicops.h",
104 "base64.cc", 111 "base64.cc",
105 "base64.h", 112 "base64.h",
106 "basictypes.h", 113 "basictypes.h",
107 "bind.h", 114 "bind.h",
108 "bitbuffer.cc", 115 "bitbuffer.cc",
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 # Dependency on chromium's logging (in //base). 209 # Dependency on chromium's logging (in //base).
203 deps += [ "//base:base" ] 210 deps += [ "//base:base" ]
204 sources += [ 211 sources += [
205 "../../webrtc_overrides/webrtc/rtc_base/logging.cc", 212 "../../webrtc_overrides/webrtc/rtc_base/logging.cc",
206 "../../webrtc_overrides/webrtc/rtc_base/logging.h", 213 "../../webrtc_overrides/webrtc/rtc_base/logging.h",
207 ] 214 ]
208 } else { 215 } else {
209 sources += [ 216 sources += [
210 "logging.cc", 217 "logging.cc",
211 "logging.h", 218 "logging.h",
212 "logging_mac.mm",
213 ] 219 ]
214 } 220 }
215 if (is_component_build && is_win) { 221 if (is_component_build && is_win) {
216 # Copy the VS runtime DLLs into the isolate so that they don't have to be 222 # Copy the VS runtime DLLs into the isolate so that they don't have to be
217 # preinstalled on the target machine. The debug runtimes have a "d" at 223 # preinstalled on the target machine. The debug runtimes have a "d" at
218 # the end. 224 # the end.
219 # This is a copy of https://codereview.chromium.org/1783973002. 225 # This is a copy of https://codereview.chromium.org/1783973002.
220 # TODO(ehmaldonado): We'd like Chromium to make this changes easier to use, 226 # TODO(ehmaldonado): We'd like Chromium to make this changes easier to use,
221 # so we don't have to copy their changes and risk breakages. 227 # so we don't have to copy their changes and risk breakages.
222 # See http://crbug.com/653569 228 # See http://crbug.com/653569
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 } else { 288 } else {
283 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_r t.asan_dynamic-i386.dll" ] 289 data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_r t.asan_dynamic-i386.dll" ]
284 } 290 }
285 } 291 }
286 } 292 }
287 if (is_nacl) { 293 if (is_nacl) {
288 deps += [ "//native_client_sdk/src/libraries/nacl_io" ] 294 deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
289 } 295 }
290 } 296 }
291 297
298 if (is_mac && !build_with_chromium) {
299 config("rtc_base_approved_objc_all_dependent_config") {
300 visibility = [ ":rtc_base_approved_objc" ]
301 libs = [ "Foundation.framework" ] # needed for logging_mac.mm
302 }
303
304 rtc_source_set("rtc_base_approved_objc") {
305 visibility = [ ":rtc_base_approved" ]
306 all_dependent_configs = [ ":rtc_base_approved_objc_all_dependent_config" ]
307 sources = [
308 "logging_mac.mm",
309 ]
310 deps = [
311 ":rtc_base_approved_generic",
312 ]
313 }
314 }
315
292 rtc_source_set("rtc_task_queue") { 316 rtc_source_set("rtc_task_queue") {
293 deps = [ 317 deps = [
294 ":rtc_base_approved", 318 ":rtc_base_approved",
295 ] 319 ]
296 public_deps = [ 320 public_deps = [
297 ":rtc_task_queue_api", 321 ":rtc_task_queue_api",
298 ] 322 ]
299 323
300 if (rtc_link_task_queue_impl) { 324 if (rtc_link_task_queue_impl) {
301 deps += [ ":rtc_task_queue_impl" ] 325 deps += [ ":rtc_task_queue_impl" ]
(...skipping 797 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 "java/src/org/webrtc/ContextUtils.java", 1123 "java/src/org/webrtc/ContextUtils.java",
1100 "java/src/org/webrtc/Logging.java", 1124 "java/src/org/webrtc/Logging.java",
1101 "java/src/org/webrtc/Size.java", 1125 "java/src/org/webrtc/Size.java",
1102 "java/src/org/webrtc/ThreadUtils.java", 1126 "java/src/org/webrtc/ThreadUtils.java",
1103 ] 1127 ]
1104 1128
1105 # TODO(sakal): Fix build hooks crbug.com/webrtc/8148 1129 # TODO(sakal): Fix build hooks crbug.com/webrtc/8148
1106 no_build_hooks = true 1130 no_build_hooks = true
1107 } 1131 }
1108 } 1132 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698