Reland of Injectable Obj-C video codecs

Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ )

Reason for revert:
New CL for fixing the issues

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ )
>
> Reason for revert:
> Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future.
>
> Original issue's description:
> > Injectable Obj-C video codecs
> >
> > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > (wrapping the VideoToolbox codec).
> >
> > Some notes / things left to do:
> >   - There are some hard-coded references to codec types that are supported by
> >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> >     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
> >     These types would need to be more codec agnostic to avoid this.
> >   - Most interfaces are borrowed from the design document for injectable
> >     codecs in Android. Some data in the corresponding C++ classes is discarded
> >     when converting to the Obj-C version, since it has fewer fields. I have not
> >     verified whether all data that we do keep is needed, or whether we might be
> >     losing anything useful in these conversions.
> >   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
> >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> >     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
> >     Decoder wrapper classes.
> >   - List the injected codec factory's supported codecs in the list of codecs in
> >     AppRTCMobile.
> >
> > BUG=webrtc:7924
> > R=magjed@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2966023002 .
> > Cr-Commit-Position: refs/heads/master@{#18928}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264
>
> TBR=magjed@webrtc.org,andersc@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7924
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2975963002
> Cr-Commit-Position: refs/heads/master@{#18979}
> Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce

R=magjed@webrtc.org
TBR=tkchin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924
Review-Url: https://codereview.webrtc.org/2981583002 .
Cr-Commit-Position: refs/heads/master@{#19002}
Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b

[andersc, 2017-07-12 08:43:19]

Created Reland of Injectable Obj-C video codecs

[andersc, 2017-07-12 11:53:25]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 11:53:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-12 11:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 11:53:36]

Dry run: This issue passed the CQ dry run.

[andersc, 2017-07-12 14:13:05]

andersc@webrtc.org changed reviewers:
+ jtteh@webrtc.org

[andersc, 2017-07-12 14:13:06]

This is the Injectable Obj-C codec CL again, but including fixes for forwarding
the return values from the wrapped video codec correctly. I have added some
regression unit tests to catch this specific issue, ideally we would have better
integration tests for the codecs and there is a separate effort underway to
enable these.

I was unable however to reproduce the issue of missing video after being in the
background state in AppRTCMobile. This fix is just based off of jtteh's code in
https://codereview.webrtc.org/2976773002/ so thanks for tracking down this
issue!

[jtt_webrtc, 2017-07-12 20:41:00]

Seems to have fixed it.

[magjed_webrtc, 2017-07-13 12:32:47]

lgtm

[andersc, 2017-07-13 13:17:55]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 13:18:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-13 13:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 13:18:02]

Dry run: This issue passed the CQ dry run.

[andersc, 2017-07-13 14:04:04]

Description was changed from

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )

Reason for revert:
New CL for fixing the issues

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
> 
> Reason for revert:
> Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.
> 
> Original issue's description:
> > Injectable Obj-C video codecs
> > 
> > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > (wrapping the VideoToolbox codec).
> > 
> > Some notes / things left to do:
> >   - There are some hard-coded references to codec types that are supported
by
> >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> >     These types would need to be more codec agnostic to avoid this.
> >   - Most interfaces are borrowed from the design document for injectable
> >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> >     when converting to the Obj-C version, since it has fewer fields. I have
not
> >     verified whether all data that we do keep is needed, or whether we might
be
> >     losing anything useful in these conversions.
> >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> >     Decoder wrapper classes.
> >   - List the injected codec factory's supported codecs in the list of codecs
in
> >     AppRTCMobile.
> > 
> > BUG=webrtc:7924
> > R=magjed@webrtc.org
> > 
> > Review-Url: https://codereview.webrtc.org/2966023002 .
> > Cr-Commit-Position: refs/heads/master@{#18928}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
> 
> TBR=magjed@webrtc.org,andersc@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7924
> NOTRY=true
> 
> Review-Url: https://codereview.webrtc.org/2975963002
> Cr-Commit-Position: refs/heads/master@{#18979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...

TBR=magjed@webrtc.org,tkchin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924
==========

to

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )

Reason for revert:
New CL for fixing the issues

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
>
> Reason for revert:
> Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.
>
> Original issue's description:
> > Injectable Obj-C video codecs
> >
> > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > (wrapping the VideoToolbox codec).
> >
> > Some notes / things left to do:
> >   - There are some hard-coded references to codec types that are supported
by
> >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> >     These types would need to be more codec agnostic to avoid this.
> >   - Most interfaces are borrowed from the design document for injectable
> >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> >     when converting to the Obj-C version, since it has fewer fields. I have
not
> >     verified whether all data that we do keep is needed, or whether we might
be
> >     losing anything useful in these conversions.
> >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> >     Decoder wrapper classes.
> >   - List the injected codec factory's supported codecs in the list of codecs
in
> >     AppRTCMobile.
> >
> > BUG=webrtc:7924
> > R=magjed@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2966023002 .
> > Cr-Commit-Position: refs/heads/master@{#18928}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
>
> TBR=magjed@webrtc.org,andersc@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7924
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2975963002
> Cr-Commit-Position: refs/heads/master@{#18979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...

R=magjed@webrtc.org
TBR=tkchin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924

Review-Url: https://codereview.webrtc.org/2981583002 .
Cr-Commit-Position: refs/heads/master@{#19002}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
==========

[andersc, 2017-07-13 14:04:06]

Committed patchset #3 (id:400001) manually as
a5f1de1e6541de03f944bcbf49be87c01f57a18b (presubmit successful).

[sprang_webrtc, 2017-07-13 14:09:25]

A revert of this CL (patchset #3 id:400001) has been created in
https://codereview.webrtc.org/2979973002/ by sprang@webrtc.org.

The reason for reverting is: Breaks bots. Build file incorrect..

[tkchin_webrtc, 2017-07-13 21:16:22]

Description was changed from

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )

Reason for revert:
New CL for fixing the issues

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
>
> Reason for revert:
> Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.
>
> Original issue's description:
> > Injectable Obj-C video codecs
> >
> > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > (wrapping the VideoToolbox codec).
> >
> > Some notes / things left to do:
> >   - There are some hard-coded references to codec types that are supported
by
> >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> >     These types would need to be more codec agnostic to avoid this.
> >   - Most interfaces are borrowed from the design document for injectable
> >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> >     when converting to the Obj-C version, since it has fewer fields. I have
not
> >     verified whether all data that we do keep is needed, or whether we might
be
> >     losing anything useful in these conversions.
> >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> >     Decoder wrapper classes.
> >   - List the injected codec factory's supported codecs in the list of codecs
in
> >     AppRTCMobile.
> >
> > BUG=webrtc:7924
> > R=magjed@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2966023002 .
> > Cr-Commit-Position: refs/heads/master@{#18928}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
>
> TBR=magjed@webrtc.org,andersc@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7924
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2975963002
> Cr-Commit-Position: refs/heads/master@{#18979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...

R=magjed@webrtc.org
TBR=tkchin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924

Review-Url: https://codereview.webrtc.org/2981583002 .
Cr-Commit-Position: refs/heads/master@{#19002}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
==========

to

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )

Reason for revert:
New CL for fixing the issues

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
>
> Reason for revert:
> Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.
>
> Original issue's description:
> > Injectable Obj-C video codecs
> >
> > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > (wrapping the VideoToolbox codec).
> >
> > Some notes / things left to do:
> >   - There are some hard-coded references to codec types that are supported
by
> >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> >     These types would need to be more codec agnostic to avoid this.
> >   - Most interfaces are borrowed from the design document for injectable
> >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> >     when converting to the Obj-C version, since it has fewer fields. I have
not
> >     verified whether all data that we do keep is needed, or whether we might
be
> >     losing anything useful in these conversions.
> >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> >     Decoder wrapper classes.
> >   - List the injected codec factory's supported codecs in the list of codecs
in
> >     AppRTCMobile.
> >
> > BUG=webrtc:7924
> > R=magjed@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2966023002 .
> > Cr-Commit-Position: refs/heads/master@{#18928}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
>
> TBR=magjed@webrtc.org,andersc@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7924
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2975963002
> Cr-Commit-Position: refs/heads/master@{#18979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...

R=magjed@webrtc.org
TBR=tkchin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924

Review-Url: https://codereview.webrtc.org/2981583002 .
Cr-Commit-Position: refs/heads/master@{#19002}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
==========

[tkchin_webrtc, 2017-07-13 21:16:22]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org

[tkchin_webrtc, 2017-07-13 21:17:00]

Chuck, can you make a pass for style / naming?

[andersc, 2017-07-14 07:20:27]

On 2017/07/13 21:17:00, tkchin_webrtc wrote:
> Chuck, can you make a pass for style / naming?

This CL was reverted due to a build file error, see instead:
https://codereview.webrtc.org/2979983002/