Reland of Injectable Obj-C video codecs

Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ )

Reason for revert:
Fix the broken build file

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ )
> 
> Reason for revert:
> Breaks bots. Build file incorrect.
> 
> Original issue's description:
> > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ )
> > 
> > Reason for revert:
> > New CL for fixing the issues
> > 
> > Original issue's description:
> > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ )
> > >
> > > Reason for revert:
> > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future.
> > >
> > > Original issue's description:
> > > > Injectable Obj-C video codecs
> > > >
> > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> > > > (wrapping the VideoToolbox codec).
> > > >
> > > > Some notes / things left to do:
> > > >   - There are some hard-coded references to codec types that are supported by
> > > >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> > > >     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
> > > >     These types would need to be more codec agnostic to avoid this.
> > > >   - Most interfaces are borrowed from the design document for injectable
> > > >     codecs in Android. Some data in the corresponding C++ classes is discarded
> > > >     when converting to the Obj-C version, since it has fewer fields. I have not
> > > >     verified whether all data that we do keep is needed, or whether we might be
> > > >     losing anything useful in these conversions.
> > > >   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
> > > >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> > > >     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
> > > >     Decoder wrapper classes.
> > > >   - List the injected codec factory's supported codecs in the list of codecs in
> > > >     AppRTCMobile.
> > > >
> > > > BUG=webrtc:7924
> > > > R=magjed@webrtc.org
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2966023002 .
> > > > Cr-Commit-Position: refs/heads/master@{#18928}
> > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264
> > >
> > > TBR=magjed@webrtc.org,andersc@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:7924
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2975963002
> > > Cr-Commit-Position: refs/heads/master@{#18979}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce
> > 
> > R=magjed@webrtc.org
> > TBR=tkchin@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7924
> > 
> > Review-Url: https://codereview.webrtc.org/2981583002 .
> > Cr-Commit-Position: refs/heads/master@{#19002}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf49be87c01f57a18b
> 
> TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7924
> 
> Review-Url: https://codereview.webrtc.org/2979973002
> Cr-Commit-Position: refs/heads/master@{#19004}
> Committed: https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04b1f40d67c2babef

TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org
BUG=webrtc:7924
Review-Url: https://codereview.webrtc.org/2979983002
Cr-Commit-Position: refs/heads/master@{#19005}
Committed: https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1cf26fce0ce3bf65

[andersc, 2017-07-13 14:22:02]

Created Reland of Injectable Obj-C video codecs

[andersc, 2017-07-13 14:22:28]

Description was changed from

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2979973002/ )

Reason for revert:
Fix the broken build file

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of
https://codereview.webrtc.org/2981583002/ )
> 
> Reason for revert:
> Breaks bots. Build file incorrect.
> 
> Original issue's description:
> > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )
> > 
> > Reason for revert:
> > New CL for fixing the issues
> > 
> > Original issue's description:
> > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
> > >
> > > Reason for revert:
> > > Causes no video in certain scenarios. Please come up with a test plan or
unit test to prevent such problems in the future.
> > >
> > > Original issue's description:
> > > > Injectable Obj-C video codecs
> > > >
> > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for
H264
> > > > (wrapping the VideoToolbox codec).
> > > >
> > > > Some notes / things left to do:
> > > >   - There are some hard-coded references to codec types that are
supported by
> > > >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo
etc
> > > >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> > > >     These types would need to be more codec agnostic to avoid this.
> > > >   - Most interfaces are borrowed from the design document for injectable
> > > >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> > > >     when converting to the Obj-C version, since it has fewer fields. I
have not
> > > >     verified whether all data that we do keep is needed, or whether we
might be
> > > >     losing anything useful in these conversions.
> > > >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> > > >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder /
decoder.
> > > >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> > > >     Decoder wrapper classes.
> > > >   - List the injected codec factory's supported codecs in the list of
codecs in
> > > >     AppRTCMobile.
> > > >
> > > > BUG=webrtc:7924
> > > > R=magjed@webrtc.org
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2966023002 .
> > > > Cr-Commit-Position: refs/heads/master@{#18928}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
> > >
> > > TBR=magjed@webrtc.org,andersc@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:7924
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2975963002
> > > Cr-Commit-Position: refs/heads/master@{#18979}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...
> > 
> > R=magjed@webrtc.org
> > TBR=tkchin@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7924
> > 
> > Review-Url: https://codereview.webrtc.org/2981583002 .
> > Cr-Commit-Position: refs/heads/master@{#19002}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
> 
> TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7924
> 
> Review-Url: https://codereview.webrtc.org/2979973002
> Cr-Commit-Position: refs/heads/master@{#19004}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04...

TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7924
==========

to

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2979973002/ )

Reason for revert:
Fix the broken build file

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of
https://codereview.webrtc.org/2981583002/ )
> 
> Reason for revert:
> Breaks bots. Build file incorrect.
> 
> Original issue's description:
> > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )
> > 
> > Reason for revert:
> > New CL for fixing the issues
> > 
> > Original issue's description:
> > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
> > >
> > > Reason for revert:
> > > Causes no video in certain scenarios. Please come up with a test plan or
unit test to prevent such problems in the future.
> > >
> > > Original issue's description:
> > > > Injectable Obj-C video codecs
> > > >
> > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for
H264
> > > > (wrapping the VideoToolbox codec).
> > > >
> > > > Some notes / things left to do:
> > > >   - There are some hard-coded references to codec types that are
supported by
> > > >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo
etc
> > > >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> > > >     These types would need to be more codec agnostic to avoid this.
> > > >   - Most interfaces are borrowed from the design document for injectable
> > > >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> > > >     when converting to the Obj-C version, since it has fewer fields. I
have not
> > > >     verified whether all data that we do keep is needed, or whether we
might be
> > > >     losing anything useful in these conversions.
> > > >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> > > >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder /
decoder.
> > > >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> > > >     Decoder wrapper classes.
> > > >   - List the injected codec factory's supported codecs in the list of
codecs in
> > > >     AppRTCMobile.
> > > >
> > > > BUG=webrtc:7924
> > > > R=magjed@webrtc.org
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2966023002 .
> > > > Cr-Commit-Position: refs/heads/master@{#18928}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
> > >
> > > TBR=magjed@webrtc.org,andersc@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:7924
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2975963002
> > > Cr-Commit-Position: refs/heads/master@{#18979}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...
> > 
> > R=magjed@webrtc.org
> > TBR=tkchin@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7924
> > 
> > Review-Url: https://codereview.webrtc.org/2981583002 .
> > Cr-Commit-Position: refs/heads/master@{#19002}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
> 
> TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7924
> 
> Review-Url: https://codereview.webrtc.org/2979973002
> Cr-Commit-Position: refs/heads/master@{#19004}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04...

TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org
BUG=webrtc:7924
==========

[andersc, 2017-07-13 14:27:25]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-13 14:27:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-13 14:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 14:51:41]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-07-13 15:56:11]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-07-13 15:56:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-13 15:59:07]

CQ is committing da patch.

Bot data: {"patchset_id": 370001, "attempt_start_ts": 1499961371703350,
"parent_rev": "81d40ee1491d5229c2677cc04b1f40d67c2babef", "commit_rev":
"732a3437da4db7b452758b8e1cf26fce0ce3bf65"}

[commit-bot: I haz the power, 2017-07-13 15:59:12]

Description was changed from

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2979973002/ )

Reason for revert:
Fix the broken build file

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of
https://codereview.webrtc.org/2981583002/ )
> 
> Reason for revert:
> Breaks bots. Build file incorrect.
> 
> Original issue's description:
> > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )
> > 
> > Reason for revert:
> > New CL for fixing the issues
> > 
> > Original issue's description:
> > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
> > >
> > > Reason for revert:
> > > Causes no video in certain scenarios. Please come up with a test plan or
unit test to prevent such problems in the future.
> > >
> > > Original issue's description:
> > > > Injectable Obj-C video codecs
> > > >
> > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for
H264
> > > > (wrapping the VideoToolbox codec).
> > > >
> > > > Some notes / things left to do:
> > > >   - There are some hard-coded references to codec types that are
supported by
> > > >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo
etc
> > > >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> > > >     These types would need to be more codec agnostic to avoid this.
> > > >   - Most interfaces are borrowed from the design document for injectable
> > > >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> > > >     when converting to the Obj-C version, since it has fewer fields. I
have not
> > > >     verified whether all data that we do keep is needed, or whether we
might be
> > > >     losing anything useful in these conversions.
> > > >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> > > >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder /
decoder.
> > > >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> > > >     Decoder wrapper classes.
> > > >   - List the injected codec factory's supported codecs in the list of
codecs in
> > > >     AppRTCMobile.
> > > >
> > > > BUG=webrtc:7924
> > > > R=magjed@webrtc.org
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2966023002 .
> > > > Cr-Commit-Position: refs/heads/master@{#18928}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
> > >
> > > TBR=magjed@webrtc.org,andersc@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:7924
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2975963002
> > > Cr-Commit-Position: refs/heads/master@{#18979}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...
> > 
> > R=magjed@webrtc.org
> > TBR=tkchin@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7924
> > 
> > Review-Url: https://codereview.webrtc.org/2981583002 .
> > Cr-Commit-Position: refs/heads/master@{#19002}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
> 
> TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7924
> 
> Review-Url: https://codereview.webrtc.org/2979973002
> Cr-Commit-Position: refs/heads/master@{#19004}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04...

TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org
BUG=webrtc:7924
==========

to

==========
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2979973002/ )

Reason for revert:
Fix the broken build file

Original issue's description:
> Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of
https://codereview.webrtc.org/2981583002/ )
> 
> Reason for revert:
> Breaks bots. Build file incorrect.
> 
> Original issue's description:
> > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of
https://codereview.webrtc.org/2975963002/ )
> > 
> > Reason for revert:
> > New CL for fixing the issues
> > 
> > Original issue's description:
> > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )
> > >
> > > Reason for revert:
> > > Causes no video in certain scenarios. Please come up with a test plan or
unit test to prevent such problems in the future.
> > >
> > > Original issue's description:
> > > > Injectable Obj-C video codecs
> > > >
> > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for
H264
> > > > (wrapping the VideoToolbox codec).
> > > >
> > > > Some notes / things left to do:
> > > >   - There are some hard-coded references to codec types that are
supported by
> > > >     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo
etc
> > > >     since we need to convert to/from these types in
ObjCVideoEncoder/Decoder.
> > > >     These types would need to be more codec agnostic to avoid this.
> > > >   - Most interfaces are borrowed from the design document for injectable
> > > >     codecs in Android. Some data in the corresponding C++ classes is
discarded
> > > >     when converting to the Obj-C version, since it has fewer fields. I
have not
> > > >     verified whether all data that we do keep is needed, or whether we
might be
> > > >     losing anything useful in these conversions.
> > > >   - Implement the VideoToolbox codec code directly in the
RTCVideoEncoderH264
> > > >     classes, instead of wrapping webrtc::H264VideoToolboxEncoder /
decoder.
> > > >     Eliminates converting between ObjC/C++ types outside the
ObjCVideoEncoder/
> > > >     Decoder wrapper classes.
> > > >   - List the injected codec factory's supported codecs in the list of
codecs in
> > > >     AppRTCMobile.
> > > >
> > > > BUG=webrtc:7924
> > > > R=magjed@webrtc.org
> > > >
> > > > Review-Url: https://codereview.webrtc.org/2966023002 .
> > > > Cr-Commit-Position: refs/heads/master@{#18928}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
> > >
> > > TBR=magjed@webrtc.org,andersc@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:7924
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2975963002
> > > Cr-Commit-Position: refs/heads/master@{#18979}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...
> > 
> > R=magjed@webrtc.org
> > TBR=tkchin@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7924
> > 
> > Review-Url: https://codereview.webrtc.org/2981583002 .
> > Cr-Commit-Position: refs/heads/master@{#19002}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a5f1de1e6541de03f944bcbf4...
> 
> TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,andersc@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7924
> 
> Review-Url: https://codereview.webrtc.org/2979973002
> Cr-Commit-Position: refs/heads/master@{#19004}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/81d40ee1491d5229c2677cc04...

TBR=magjed@webrtc.org,tkchin@webrtc.org,jtteh@webrtc.org,sprang@webrtc.org
BUG=webrtc:7924

Review-Url: https://codereview.webrtc.org/2979983002
Cr-Commit-Position: refs/heads/master@{#19005}
Committed:
https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1...
==========

[commit-bot: I haz the power, 2017-07-13 15:59:14]

Committed patchset #2 (id:370001) as
https://chromium.googlesource.com/external/webrtc/+/732a3437da4db7b452758b8e1...

[Chuck, 2017-07-14 14:57:28]

haysc@webrtc.org changed reviewers:
+ haysc@webrtc.org

[Chuck, 2017-07-14 14:57:31]

Reviewing for objc api issues per tkchin's request.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm
(right):

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm:31: -
(instancetype)initWithEncodedImage:(webrtc::EncodedImage)encodedImage {
Naming pattern in this API has generally been: initWithNativeX and createNativeX
or nativeX for init and the toCpp method.

RTCIceServer.mm and RTCConfiguration.mm both have examples.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm
(right):

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm:88:
if (encoderFactory) {
Both jtteh and I misread this code on the first pass because the names are so
similar encoder_factory vs encoderFactory - consider renaming
encoder_factory/decoder_factory for clarity.

Our mistake was looking at this code and thinking it would never execute the if
blocks.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCRtpFragmentationHeader.mm
(right):

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCRtpFragmentationHeader.mm:23:
(const webrtc::RTPFragmentationHeader *__nullable)fragmentationHeader {
What does nullable mean here for a native pointer?

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCRtpFragmentationHeader.mm:48:
webrtc::RTPFragmentationHeader *fragmentationHeader = new
webrtc::RTPFragmentationHeader;
In cases where we return a native pointer we should be using std::unique_ptr,
see example in RTCConfiguration.mm createNativeConfiguration

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm (right):

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:24: -
(instancetype)initWithPayload:(int)payload
Avoid int whenever possible in objc APIs, NSInteger is the preferred type.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:48:
cricket::VideoCodec codec(webrtc::ios::StdStringFromNSString(_name));
Prefer using the category in NSString+StdString.h instead of helpers.h instead
of StdStringFromNSString throughout.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:49: for
(NSString *paramKey in [_parameters allKeys]) {
Prefer dot syntax for properties (_parameters.allKeys)

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:59:
@implementation RTCVideoEncoderSettings
Each class should be in its own file.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:71: -
(instancetype)initWithVideoCodec:(const webrtc::VideoCodec
*__nullable)videoCodec {
Same question about nullable

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h (right):

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:21: EmptyFrame,
Enum values should be prefixed with enum name: RTCFrameTypeEmptyFrame,
RTCFrameTypeVideoFrameKey,...

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:30:
@property(nonatomic, retain) NSData *buffer;
Use strong instead of retain for consistency throughout.

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:111: -
(instancetype)initWithCodecInfo:(RTCVideoCodecInfo *)codecInfo;
init methods in a protocol seems very weird, why is this necessary?

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:113: -
(int)initEncodeWithSettings:(RTCVideoEncoderSettings *)settings
numberOfCores:(int)numberOfCores;
Do these need to be int? Prefer NSInteger

https://codereview.webrtc.org/2979983002/diff/370001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h:113: -
(int)initEncodeWithSettings:(RTCVideoEncoderSettings *)settings
numberOfCores:(int)numberOfCores;
init methods should return instancetype

[jtt_webrtc, 2017-07-15 02:30:09]

A revert of this CL (patchset #2 id:370001) has been created in
https://codereview.webrtc.org/2980173002/ by jtteh@webrtc.org.

The reason for reverting is: Still having problems with no video. Reverting.
Once no video is visible, no video is available from then on even if the callee
app is in the foreground.
.