Revert of Injectable Obj-C video codecs

Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ )

Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future.

Original issue's description:
> Injectable Obj-C video codecs
> 
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
> 
> Some notes / things left to do:
>   - There are some hard-coded references to codec types that are supported by
>     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
>     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
>     These types would need to be more codec agnostic to avoid this.
>   - Most interfaces are borrowed from the design document for injectable
>     codecs in Android. Some data in the corresponding C++ classes is discarded
>     when converting to the Obj-C version, since it has fewer fields. I have not
>     verified whether all data that we do keep is needed, or whether we might be
>     losing anything useful in these conversions.
>   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
>     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
>     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
>     Decoder wrapper classes.
>   - List the injected codec factory's supported codecs in the list of codecs in
>     AppRTCMobile.
> 
> BUG=webrtc:7924
> R=magjed@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264

TBR=magjed@webrtc.org,andersc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7924
NOTRY=true

Review-Url: https://codereview.webrtc.org/2975963002
Cr-Commit-Position: refs/heads/master@{#18979}
Committed: https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc560a8f6475a7978ce

[tkchin_webrtc, 2017-07-11 19:42:51]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2017-07-11 19:42:52]

Created Revert of Injectable Obj-C video codecs

[commit-bot: I haz the power, 2017-07-11 19:43:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-11 20:13:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 20:13:14]

Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/9610)

[tkchin_webrtc, 2017-07-11 20:15:11]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2017-07-11 20:15:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-11 20:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 20:49:31]

Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/9612)

[tkchin_webrtc, 2017-07-11 20:53:14]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2017-07-11 20:53:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-11 21:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 21:20:27]

Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/9615)

[tkchin_webrtc, 2017-07-11 22:43:05]

Description was changed from

==========
Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )

Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.

Original issue's description:
> Injectable Obj-C video codecs
> 
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
> 
> Some notes / things left to do:
>   - There are some hard-coded references to codec types that are supported by
>     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
>     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
>     These types would need to be more codec agnostic to avoid this.
>   - Most interfaces are borrowed from the design document for injectable
>     codecs in Android. Some data in the corresponding C++ classes is discarded
>     when converting to the Obj-C version, since it has fewer fields. I have
not
>     verified whether all data that we do keep is needed, or whether we might
be
>     losing anything useful in these conversions.
>   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
>     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
>     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
>     Decoder wrapper classes.
>   - List the injected codec factory's supported codecs in the list of codecs
in
>     AppRTCMobile.
> 
> BUG=webrtc:7924
> R=magjed@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...

TBR=magjed@webrtc.org,andersc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7924
==========

to

==========
Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )

Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.

Original issue's description:
> Injectable Obj-C video codecs
> 
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
> 
> Some notes / things left to do:
>   - There are some hard-coded references to codec types that are supported by
>     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
>     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
>     These types would need to be more codec agnostic to avoid this.
>   - Most interfaces are borrowed from the design document for injectable
>     codecs in Android. Some data in the corresponding C++ classes is discarded
>     when converting to the Obj-C version, since it has fewer fields. I have
not
>     verified whether all data that we do keep is needed, or whether we might
be
>     losing anything useful in these conversions.
>   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
>     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
>     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
>     Decoder wrapper classes.
>   - List the injected codec factory's supported codecs in the list of codecs
in
>     AppRTCMobile.
> 
> BUG=webrtc:7924
> R=magjed@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...

TBR=magjed@webrtc.org,andersc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7924
NOTRY=true
==========

[tkchin_webrtc, 2017-07-11 22:43:13]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2017-07-11 22:43:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-11 22:46:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499812993302500, "parent_rev":
"aa41f0cfa64ece911ae2ecee83fc3190d4a42935", "commit_rev":
"1095ada7ad56fe29b7b2bbc560a8f6475a7978ce"}

[commit-bot: I haz the power, 2017-07-11 22:46:36]

Description was changed from

==========
Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )

Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.

Original issue's description:
> Injectable Obj-C video codecs
> 
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
> 
> Some notes / things left to do:
>   - There are some hard-coded references to codec types that are supported by
>     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
>     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
>     These types would need to be more codec agnostic to avoid this.
>   - Most interfaces are borrowed from the design document for injectable
>     codecs in Android. Some data in the corresponding C++ classes is discarded
>     when converting to the Obj-C version, since it has fewer fields. I have
not
>     verified whether all data that we do keep is needed, or whether we might
be
>     losing anything useful in these conversions.
>   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
>     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
>     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
>     Decoder wrapper classes.
>   - List the injected codec factory's supported codecs in the list of codecs
in
>     AppRTCMobile.
> 
> BUG=webrtc:7924
> R=magjed@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...

TBR=magjed@webrtc.org,andersc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7924
NOTRY=true
==========

to

==========
Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of
https://codereview.webrtc.org/2966023002/ )

Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit
test to prevent such problems in the future.

Original issue's description:
> Injectable Obj-C video codecs
> 
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
> 
> Some notes / things left to do:
>   - There are some hard-coded references to codec types that are supported by
>     webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
>     since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
>     These types would need to be more codec agnostic to avoid this.
>   - Most interfaces are borrowed from the design document for injectable
>     codecs in Android. Some data in the corresponding C++ classes is discarded
>     when converting to the Obj-C version, since it has fewer fields. I have
not
>     verified whether all data that we do keep is needed, or whether we might
be
>     losing anything useful in these conversions.
>   - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
>     classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
>     Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
>     Decoder wrapper classes.
>   - List the injected codec factory's supported codecs in the list of codecs
in
>     AppRTCMobile.
> 
> BUG=webrtc:7924
> R=magjed@webrtc.org
> 
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...

TBR=magjed@webrtc.org,andersc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7924
NOTRY=true

Review-Url: https://codereview.webrtc.org/2975963002
Cr-Commit-Position: refs/heads/master@{#18979}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...
==========

[commit-bot: I haz the power, 2017-07-11 22:46:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1095ada7ad56fe29b7b2bbc56...

[andersc, 2017-07-12 08:43:18]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2981583002/ by andersc@webrtc.org.

The reason for reverting is: New CL for fixing the issues.