Injectable Obj-C video codecs

Injectable Obj-C video codecs

Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
R=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2966023002 .
Cr-Commit-Position: refs/heads/master@{#18928}
Committed: https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6c837f5f4758e264

[andersc, 2017-07-04 09:34:04]

Description was changed from

==========
Injectable Obj-C video codecs

Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
==========

to

==========
Injectable Obj-C video codecs

Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
==========

[andersc, 2017-07-04 09:34:04]

andersc@webrtc.org changed reviewers:
+ magjed@webrtc.org

[andersc, 2017-07-04 09:52:48]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 09:52:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-04 09:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 09:57:45]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/22843)

[andersc, 2017-07-04 11:45:21]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 11:45:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-04 11:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 11:48:16]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/26009)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/22851)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/27111)

[andersc, 2017-07-04 12:21:31]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 12:21:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-04 12:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 12:24:27]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/26011)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/22853)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/27113)

[andersc, 2017-07-04 13:16:37]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 13:16:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-04 13:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 13:42:53]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-07-04 14:08:33]

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCMobile/ARDAppClient.m (right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCMobile/ARDAppClient.m:25: #import
"WebRTC/RTCVideoCodecFactory.h"
This include looks unnecessary.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm (right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:79: if
(videoCodec->codecType == webrtc::kVideoCodecH264) {
Can you use CodecTypeToPayloadName(VideoCodecType type) and create the NSString
from the returned const char*?

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:102:
codecSettings->codecType = webrtc::kVideoCodecH264;
You can use PayloadNameToCodecType here.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:2: * 
Copyright 2017 The WebRTC project authors. All Rights Reserved.
This file is very similar to sdk/objc/Framework/Classes/VideoToolbox/encoder.mm?
Can you re-upload with 'git cl upload --similarity 10' to see if we can get the
diff to work?

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm:38:
numberOfCores:number_of_cores];
Why do we need to pass number of cores here?

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_encoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_encoder_factory.mm:77:
static_cast<ObjCFrameBuffer
*>(frame.video_frame_buffer().get())->wrapped_frame_buffer();
Maybe we should assert that the buffer type is kNative here.

[andersc, 2017-07-04 15:10:42]

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCMobile/ARDAppClient.m (right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCMobile/ARDAppClient.m:25: #import
"WebRTC/RTCVideoCodecFactory.h"
On 2017/07/04 14:08:32, magjed_webrtc wrote:
> This include looks unnecessary.

Done.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm (right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:79: if
(videoCodec->codecType == webrtc::kVideoCodecH264) {
On 2017/07/04 14:08:32, magjed_webrtc wrote:
> Can you use CodecTypeToPayloadName(VideoCodecType type) and create the
NSString
> from the returned const char*?

Done.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:102:
codecSettings->codecType = webrtc::kVideoCodecH264;
On 2017/07/04 14:08:32, magjed_webrtc wrote:
> You can use PayloadNameToCodecType here.

Done.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:2: * 
Copyright 2017 The WebRTC project authors. All Rights Reserved.
On 2017/07/04 14:08:32, magjed_webrtc wrote:
> This file is very similar to
sdk/objc/Framework/Classes/VideoToolbox/encoder.mm?
> Can you re-upload with 'git cl upload --similarity 10' to see if we can get
the
> diff to work?

Is that useful? This is not the same file, this one is written from scratch and
wraps VideoToolbox/encoder.mm and decoder.mm

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm:38:
numberOfCores:number_of_cores];
On 2017/07/04 14:08:33, magjed_webrtc wrote:
> Why do we need to pass number of cores here?

Done.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_encoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_encoder_factory.mm:77:
static_cast<ObjCFrameBuffer
*>(frame.video_frame_buffer().get())->wrapped_frame_buffer();
On 2017/07/04 14:08:33, magjed_webrtc wrote:
> Maybe we should assert that the buffer type is kNative here.

Done.

[magjed_webrtc, 2017-07-05 13:22:35]

I would like to move RTCEncodedImage.h and RTCRtpFragmentationHeader.h into
RTCVideoCodec.h as well, in order to reduce the number of public headers.

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
(right):

https://codereview.webrtc.org/2966023002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:2: * 
Copyright 2017 The WebRTC project authors. All Rights Reserved.
On 2017/07/04 15:10:41, andersc wrote:
> On 2017/07/04 14:08:32, magjed_webrtc wrote:
> > This file is very similar to
> sdk/objc/Framework/Classes/VideoToolbox/encoder.mm?
> > Can you re-upload with 'git cl upload --similarity 10' to see if we can get
> the
> > diff to work?
> 
> Is that useful? This is not the same file, this one is written from scratch
and
> wraps VideoToolbox/encoder.mm and decoder.mm

Sorry, my bad. I didn't realize it was written from scratch.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:487: "../media:rtc_audio_video",
I guess you have a reason for adding these seemingly unrelated deps?

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm:15: // An
encoded frame
Comment that this is an ObjC wrapper for webrtc::EncodedImage. Also, end the
sentence with a dot. Update the comments in the other files as well.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:14:
#import <WebRTC/RTCVideoCodecH264.h>
This should be the first import.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:18:
#include <vector>
This include should be before webrtc imports/includes.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm:24:
#include
"webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.h"
This should be the first include.

[andersc, 2017-07-06 12:39:42]

Moved the files with media dependencies into the target that compiles without
the `HAVE_NO_MEDIA` flag. Will move videotoolbox related files into the
videotoolbox target in separate CL that deals with the H264 codec.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:487: "../media:rtc_audio_video",
On 2017/07/05 13:22:32, magjed_webrtc wrote:
> I guess you have a reason for adding these seemingly unrelated deps?

Acknowledged.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm:15: // An
encoded frame
On 2017/07/05 13:22:32, magjed_webrtc wrote:
> Comment that this is an ObjC wrapper for webrtc::EncodedImage. Also, end the
> sentence with a dot. Update the comments in the other files as well.

Done.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:14:
#import <WebRTC/RTCVideoCodecH264.h>
On 2017/07/05 13:22:32, magjed_webrtc wrote:
> This should be the first import.

Done.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm:18:
#include <vector>
On 2017/07/05 13:22:32, magjed_webrtc wrote:
> This include should be before webrtc imports/includes.

Done.

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
File
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm
(right):

https://codereview.webrtc.org/2966023002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.mm:24:
#include
"webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_decoder_factory.h"
On 2017/07/05 13:22:33, magjed_webrtc wrote:
> This should be the first include.

Done.

[andersc, 2017-07-06 12:40:04]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 12:40:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-06 13:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 13:30:53]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-07-06 14:33:07]

lgtm!

https://codereview.webrtc.org/2966023002/diff/100001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2966023002/diff/100001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:490: "../modules:module_api",
I hope this dependency doesn't increase the binary size a lot for the no-media
case. Otherwise we need to remove it.

[andersc, 2017-07-07 10:31:45]

The CQ bit was checked by andersc@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 10:31:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-07 10:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 10:54:27]

Dry run: This issue passed the CQ dry run.

[andersc, 2017-07-07 11:19:22]

Description was changed from

==========
Injectable Obj-C video codecs

Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
==========

to

==========
Injectable Obj-C video codecs

Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
R=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2966023002 .
Cr-Commit-Position: refs/heads/master@{#18928}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a0349c138db62c52435be84b6...
==========

[andersc, 2017-07-07 11:19:23]

Committed patchset #8 (id:140001) manually as
a0349c138db62c52435be84b6c837f5f4758e264 (presubmit successful).

[tkchin_webrtc, 2017-07-11 19:42:51]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.webrtc.org/2975963002/ by tkchin@webrtc.org.

The reason for reverting is: Causes no video in certain scenarios. Please come
up with a test plan or unit test to prevent such problems in the future..