Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2913793002: Address some violations of chromium-style. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Address some violations of chromium-style. BUG=webrtc:163 Review-Url: https://codereview.webrtc.org/2913793002 Cr-Commit-Position: refs/heads/master@{#18345} Committed: https://chromium.googlesource.com/external/webrtc/+/76e62b0d3861c94a9c9ab780ee8bde888ac08170

Patch Set 1 #

Total comments: 8

Patch Set 2 : Add empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -38 lines) Patch
M webrtc/call/rtp_transport_controller_send.h View 1 chunk +4 lines, -8 lines 0 comments Download
M webrtc/call/rtp_transport_controller_send.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/call/rtx_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/rtx_receive_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/bwe_defines.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 3 chunks +7 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +20 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nisse-webrtc
PTAL. The warnings appeared on a local branch where I moved the RtpTransportController-related code out ...
3 years, 6 months ago (2017-05-30 14:46:58 UTC) #2
danilchap
lgtm https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/send_side_congestion_controller.cc File webrtc/modules/congestion_controller/send_side_congestion_controller.cc (right): https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/send_side_congestion_controller.cc#newcode187 webrtc/modules/congestion_controller/send_side_congestion_controller.cc:187: TransportFeedbackObserver* add an empty line above
3 years, 6 months ago (2017-05-30 14:55:39 UTC) #3
kwiberg-webrtc
lgtm. Keep using "inline" or not as you see fit. https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h File webrtc/modules/congestion_controller/delay_based_bwe.h (left): https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h#oldcode48 ...
3 years, 6 months ago (2017-05-31 08:22:28 UTC) #5
nisse-webrtc
https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h File webrtc/modules/congestion_controller/delay_based_bwe.h (left): https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h#oldcode48 webrtc/modules/congestion_controller/delay_based_bwe.h:48: virtual ~DelayBasedBwe() {} On 2017/05/31 08:22:27, kwiberg-webrtc wrote: > ...
3 years, 6 months ago (2017-05-31 08:44:54 UTC) #6
kwiberg-webrtc
https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h File webrtc/modules/congestion_controller/delay_based_bwe.h (left): https://codereview.webrtc.org/2913793002/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.h#oldcode48 webrtc/modules/congestion_controller/delay_based_bwe.h:48: virtual ~DelayBasedBwe() {} On 2017/05/31 08:44:54, nisse-webrtc wrote: > ...
3 years, 6 months ago (2017-05-31 08:49:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2913793002/20001
3 years, 6 months ago (2017-05-31 08:59:34 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:24:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/76e62b0d3861c94a9c9ab780e...

Powered by Google App Engine
This is Rietveld 408576698