Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2913793002: Address some violations of chromium-style. (Closed)
Patch Set: Add empty line. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff), 167 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff),
168 trendline_threshold_gain_(kDefaultTrendlineThresholdGain), 168 trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
169 consecutive_delayed_feedbacks_(0), 169 consecutive_delayed_feedbacks_(0),
170 last_logged_bitrate_(0), 170 last_logged_bitrate_(0),
171 last_logged_state_(BandwidthUsage::kBwNormal), 171 last_logged_state_(BandwidthUsage::kBwNormal),
172 in_sparse_update_experiment_(BweSparseUpdateExperimentIsEnabled()) { 172 in_sparse_update_experiment_(BweSparseUpdateExperimentIsEnabled()) {
173 LOG(LS_INFO) << "Using Trendline filter for delay change estimation."; 173 LOG(LS_INFO) << "Using Trendline filter for delay change estimation.";
174 network_thread_.DetachFromThread(); 174 network_thread_.DetachFromThread();
175 } 175 }
176 176
177 DelayBasedBwe::~DelayBasedBwe() {}
178
177 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector( 179 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
178 const std::vector<PacketFeedback>& packet_feedback_vector) { 180 const std::vector<PacketFeedback>& packet_feedback_vector) {
179 RTC_DCHECK(network_thread_.CalledOnValidThread()); 181 RTC_DCHECK(network_thread_.CalledOnValidThread());
180 182
181 std::vector<PacketFeedback> sorted_packet_feedback_vector; 183 std::vector<PacketFeedback> sorted_packet_feedback_vector;
182 SortPacketFeedbackVector(packet_feedback_vector, 184 SortPacketFeedbackVector(packet_feedback_vector,
183 &sorted_packet_feedback_vector); 185 &sorted_packet_feedback_vector);
184 // TOOD(holmer): An empty feedback vector here likely means that 186 // TOOD(holmer): An empty feedback vector here likely means that
185 // all acks were too late and that the send time history had 187 // all acks were too late and that the send time history had
186 // timed out. We should reduce the rate when this occurs. 188 // timed out. We should reduce the rate when this occurs.
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) { 367 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
366 // Called from both the configuration thread and the network thread. Shouldn't 368 // Called from both the configuration thread and the network thread. Shouldn't
367 // be called from the network thread in the future. 369 // be called from the network thread in the future.
368 rate_control_.SetMinBitrate(min_bitrate_bps); 370 rate_control_.SetMinBitrate(min_bitrate_bps);
369 } 371 }
370 372
371 int64_t DelayBasedBwe::GetExpectedBwePeriodMs() const { 373 int64_t DelayBasedBwe::GetExpectedBwePeriodMs() const {
372 return rate_control_.GetExpectedBandwidthPeriodMs(); 374 return rate_control_.GetExpectedBandwidthPeriodMs();
373 } 375 }
374 } // namespace webrtc 376 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698