Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2913793002: Address some violations of chromium-style. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 struct Result { 38 struct Result {
39 Result() : updated(false), probe(false), target_bitrate_bps(0) {} 39 Result() : updated(false), probe(false), target_bitrate_bps(0) {}
40 Result(bool probe, uint32_t target_bitrate_bps) 40 Result(bool probe, uint32_t target_bitrate_bps)
41 : updated(true), probe(probe), target_bitrate_bps(target_bitrate_bps) {} 41 : updated(true), probe(probe), target_bitrate_bps(target_bitrate_bps) {}
42 bool updated; 42 bool updated;
43 bool probe; 43 bool probe;
44 uint32_t target_bitrate_bps; 44 uint32_t target_bitrate_bps;
45 }; 45 };
46 46
47 DelayBasedBwe(RtcEventLog* event_log, const Clock* clock); 47 DelayBasedBwe(RtcEventLog* event_log, const Clock* clock);
48 virtual ~DelayBasedBwe() {} 48 virtual ~DelayBasedBwe();
kwiberg-webrtc 2017/05/31 08:22:27 Hmm. Why is this destructor virtual? Nothing else
nisse-webrtc 2017/05/31 08:44:54 No idea, I'm afraid. Do you want me to change it?
kwiberg-webrtc 2017/05/31 08:49:48 No, at least not in this CL. I was just asking in
49 49
50 Result IncomingPacketFeedbackVector( 50 Result IncomingPacketFeedbackVector(
51 const std::vector<PacketFeedback>& packet_feedback_vector); 51 const std::vector<PacketFeedback>& packet_feedback_vector);
52 void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms); 52 void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms);
53 bool LatestEstimate(std::vector<uint32_t>* ssrcs, 53 bool LatestEstimate(std::vector<uint32_t>* ssrcs,
54 uint32_t* bitrate_bps) const; 54 uint32_t* bitrate_bps) const;
55 void SetStartBitrate(int start_bitrate_bps); 55 void SetStartBitrate(int start_bitrate_bps);
56 void SetMinBitrate(int min_bitrate_bps); 56 void SetMinBitrate(int min_bitrate_bps);
57 int64_t GetExpectedBwePeriodMs() const; 57 int64_t GetExpectedBwePeriodMs() const;
58 58
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 uint32_t last_logged_bitrate_; 106 uint32_t last_logged_bitrate_;
107 BandwidthUsage last_logged_state_; 107 BandwidthUsage last_logged_state_;
108 bool in_sparse_update_experiment_; 108 bool in_sparse_update_experiment_;
109 109
110 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe); 110 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
111 }; 111 };
112 112
113 } // namespace webrtc 113 } // namespace webrtc
114 114
115 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_ 115 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698