Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2913793002: Address some violations of chromium-style. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 virtual void OnRttUpdate(int64_t rtt) = 0; 377 virtual void OnRttUpdate(int64_t rtt) = 0;
378 378
379 virtual int64_t LastProcessedRtt() const = 0; 379 virtual int64_t LastProcessedRtt() const = 0;
380 380
381 virtual ~RtcpRttStats() {} 381 virtual ~RtcpRttStats() {}
382 }; 382 };
383 383
384 // Null object version of RtpFeedback. 384 // Null object version of RtpFeedback.
385 class NullRtpFeedback : public RtpFeedback { 385 class NullRtpFeedback : public RtpFeedback {
386 public: 386 public:
387 virtual ~NullRtpFeedback() {} 387 ~NullRtpFeedback() override {}
388 388
389 int32_t OnInitializeDecoder(int8_t payload_type, 389 int32_t OnInitializeDecoder(int8_t payload_type,
390 const char payloadName[RTP_PAYLOAD_NAME_SIZE], 390 const char payloadName[RTP_PAYLOAD_NAME_SIZE],
391 int frequency, 391 int frequency,
392 size_t channels, 392 size_t channels,
393 uint32_t rate) override { 393 uint32_t rate) override;
394 return 0;
395 }
396 394
397 void OnIncomingSSRCChanged(uint32_t ssrc) override {} 395 void OnIncomingSSRCChanged(uint32_t ssrc) override {}
398 void OnIncomingCSRCChanged(uint32_t csrc, bool added) override {} 396 void OnIncomingCSRCChanged(uint32_t csrc, bool added) override {}
399 }; 397 };
400 398
399 inline int32_t NullRtpFeedback::OnInitializeDecoder(
kwiberg-webrtc 2017/05/31 08:22:28 I'm not sure I like the use of "inline" here---you
nisse-webrtc 2017/05/31 08:44:54 I'm not sure what's the background for the warning
kwiberg-webrtc 2017/05/31 08:49:48 Binary size. It warns about inlined constructors,
400 int8_t payload_type,
401 const char payloadName[RTP_PAYLOAD_NAME_SIZE],
402 int frequency,
403 size_t channels,
404 uint32_t rate) {
405 return 0;
406 }
407
401 // Null object version of RtpData. 408 // Null object version of RtpData.
402 class NullRtpData : public RtpData { 409 class NullRtpData : public RtpData {
403 public: 410 public:
404 virtual ~NullRtpData() {} 411 ~NullRtpData() override {}
405 412
406 int32_t OnReceivedPayloadData(const uint8_t* payload_data, 413 int32_t OnReceivedPayloadData(const uint8_t* payload_data,
407 size_t payload_size, 414 size_t payload_size,
408 const WebRtcRTPHeader* rtp_header) override { 415 const WebRtcRTPHeader* rtp_header) override;
409 return 0;
410 }
411 }; 416 };
412 417
418 inline int32_t NullRtpData::OnReceivedPayloadData(
419 const uint8_t* payload_data,
420 size_t payload_size,
421 const WebRtcRTPHeader* rtp_header) {
422 return 0;
423 }
424
413 // Statistics about packet loss for a single directional connection. All values 425 // Statistics about packet loss for a single directional connection. All values
414 // are totals since the connection initiated. 426 // are totals since the connection initiated.
415 struct RtpPacketLossStats { 427 struct RtpPacketLossStats {
416 // The number of packets lost in events where no adjacent packets were also 428 // The number of packets lost in events where no adjacent packets were also
417 // lost. 429 // lost.
418 uint64_t single_packet_loss_count; 430 uint64_t single_packet_loss_count;
419 // The number of events in which more than one adjacent packet was lost. 431 // The number of events in which more than one adjacent packet was lost.
420 uint64_t multiple_packet_loss_event_count; 432 uint64_t multiple_packet_loss_event_count;
421 // The number of packets lost in events where more than one adjacent packet 433 // The number of packets lost in events where more than one adjacent packet
422 // was lost. 434 // was lost.
(...skipping 26 matching lines...) Expand all
449 class TransportSequenceNumberAllocator { 461 class TransportSequenceNumberAllocator {
450 public: 462 public:
451 TransportSequenceNumberAllocator() {} 463 TransportSequenceNumberAllocator() {}
452 virtual ~TransportSequenceNumberAllocator() {} 464 virtual ~TransportSequenceNumberAllocator() {}
453 465
454 virtual uint16_t AllocateSequenceNumber() = 0; 466 virtual uint16_t AllocateSequenceNumber() = 0;
455 }; 467 };
456 468
457 } // namespace webrtc 469 } // namespace webrtc
458 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_ 470 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698