Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2878733004: Fixing check_orphan_headers on Windows (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing check_orphan_headers on Windows There were too many assumptions of the fact that the check was running on Linux. BUG=webrtc:7635 NOTRY=True Review-Url: https://codereview.webrtc.org/2878733004 Cr-Commit-Position: refs/heads/master@{#18120} Committed: https://chromium.googlesource.com/external/webrtc/+/26c26345c3faf0b2ea5f09583ceeba133a2687e2

Patch Set 1 #

Patch Set 2 : Removing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M tools_webrtc/presubmit_checks_lib/check_orphan_headers.py View 2 chunks +5 lines, -1 line 0 comments Download
M tools_webrtc/presubmit_checks_lib/check_orphan_headers_test.py View 4 chunks +37 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mbonadei
3 years, 7 months ago (2017-05-12 07:59:06 UTC) #2
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-05-12 08:58:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2878733004/20001
3 years, 7 months ago (2017-05-12 09:03:25 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 09:06:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/26c26345c3faf0b2ea5f09583...

Powered by Google App Engine
This is Rietveld 408576698