Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

Issue 2878733004: Fixing check_orphan_headers on Windows (Closed)
Patch Set: Removing comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | tools_webrtc/presubmit_checks_lib/check_orphan_headers_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
diff --git a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
index 6c14aad2a4ce69b53c88cfcb4b4165fbe43f70ec..04291669ebbdee5076691dcc8028b2784b5d6659 100644
--- a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
+++ b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py
@@ -9,6 +9,7 @@
import os
import re
+import string
# TARGET_RE matches a GN target, and extracts the target name and the contents.
@@ -112,5 +113,8 @@ def GetHeadersInBuildGnFileSources(file_content, target_abs_path):
for source_file_match in SOURCE_FILE_RE.finditer(sources):
source_file = source_file_match.group('source_file')
if source_file.endswith('.h'):
- headers_in_sources.add(os.path.join(target_abs_path, source_file))
+ source_file_tokens = string.split(source_file, '/')
+ # pylint: disable=star-args
+ headers_in_sources.add(os.path.join(target_abs_path,
+ *source_file_tokens))
return headers_in_sources
« no previous file with comments | « PRESUBMIT.py ('k') | tools_webrtc/presubmit_checks_lib/check_orphan_headers_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698