PRESUBMIT.py - Issue 2878733004: Fixing check_orphan_headers on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2878733004: Fixing check_orphan_headers on Windows (Closed)

Patch Set: Removing comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index e1dec872b147c982a96cd3d90ec54a2643d84f4e..e2d0dd50d092b8699e208273f40864e6061a4d0a 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -575,10 +575,7 @@ def _CommonChecks(input_api, output_api):

results.extend(_CheckJSONParseErrors(input_api, output_api))

results.extend(_RunPythonTests(input_api, output_api))

results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api))

- # Disabling this because it seems to have a bug when running on Windows.

- # TODO(mbonadei): fix this and re-enable this check.

- # BUG: https://bugs.chromium.org/p/webrtc/issues/detail?id=7635

- # results.extend(_CheckOrphanHeaders(input_api, output_api))

+ results.extend(_CheckOrphanHeaders(input_api, output_api))

return results

« no previous file with comments | « no previous file | tools_webrtc/presubmit_checks_lib/check_orphan_headers.py » ('j') | no next file with comments »