Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: PRESUBMIT.py

Issue 2878733004: Fixing check_orphan_headers on Windows (Closed)
Patch Set: Removing comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools_webrtc/presubmit_checks_lib/check_orphan_headers.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 input_api, output_api)) 568 input_api, output_api))
569 results.extend(_CheckNativeApiHeaderChanges(input_api, output_api)) 569 results.extend(_CheckNativeApiHeaderChanges(input_api, output_api))
570 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) 570 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
571 results.extend(_CheckNoPragmaOnce(input_api, output_api)) 571 results.extend(_CheckNoPragmaOnce(input_api, output_api))
572 results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) 572 results.extend(_CheckNoFRIEND_TEST(input_api, output_api))
573 results.extend(_CheckGnChanges(input_api, output_api)) 573 results.extend(_CheckGnChanges(input_api, output_api))
574 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 574 results.extend(_CheckUnwantedDependencies(input_api, output_api))
575 results.extend(_CheckJSONParseErrors(input_api, output_api)) 575 results.extend(_CheckJSONParseErrors(input_api, output_api))
576 results.extend(_RunPythonTests(input_api, output_api)) 576 results.extend(_RunPythonTests(input_api, output_api))
577 results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api)) 577 results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api))
578 # Disabling this because it seems to have a bug when running on Windows. 578 results.extend(_CheckOrphanHeaders(input_api, output_api))
579 # TODO(mbonadei): fix this and re-enable this check.
580 # BUG: https://bugs.chromium.org/p/webrtc/issues/detail?id=7635
581 # results.extend(_CheckOrphanHeaders(input_api, output_api))
582 return results 579 return results
583 580
584 581
585 def CheckChangeOnUpload(input_api, output_api): 582 def CheckChangeOnUpload(input_api, output_api):
586 results = [] 583 results = []
587 results.extend(_CommonChecks(input_api, output_api)) 584 results.extend(_CommonChecks(input_api, output_api))
588 results.extend( 585 results.extend(
589 input_api.canned_checks.CheckGNFormatted(input_api, output_api)) 586 input_api.canned_checks.CheckGNFormatted(input_api, output_api))
590 return results 587 return results
591 588
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 if f.LocalPath().endswith('.h') and f.Action() == 'A': 626 if f.LocalPath().endswith('.h') and f.Action() == 'A':
630 file_path = os.path.abspath(f.LocalPath()) 627 file_path = os.path.abspath(f.LocalPath())
631 root_dir = os.getcwd() 628 root_dir = os.getcwd()
632 gn_file_path = GetBuildGnPathFromFilePath(file_path, os.path.exists, 629 gn_file_path = GetBuildGnPathFromFilePath(file_path, os.path.exists,
633 root_dir) 630 root_dir)
634 in_build_gn = IsHeaderInBuildGn(file_path, gn_file_path) 631 in_build_gn = IsHeaderInBuildGn(file_path, gn_file_path)
635 if not in_build_gn: 632 if not in_build_gn:
636 results.append(output_api.PresubmitError(error_msg.format( 633 results.append(output_api.PresubmitError(error_msg.format(
637 file_path, gn_file_path))) 634 file_path, gn_file_path)))
638 return results 635 return results
OLDNEW
« no previous file with comments | « no previous file | tools_webrtc/presubmit_checks_lib/check_orphan_headers.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698