Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2857933002: Replace VideoSendStream::Config with new rtclog::StreamConfig in RtcEventLog. (Closed)

Created:
3 years, 7 months ago by perkj_webrtc
Modified:
3 years, 7 months ago
Reviewers:
the sun, terelius
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace VideoSendStream::Config with new rtclog::StreamConfig in RtcEventLog. BUG=webrtc:7538 Review-Url: https://codereview.webrtc.org/2857933002 Cr-Commit-Position: refs/heads/master@{#18221} Committed: https://chromium.googlesource.com/external/webrtc/+/c0876aab46356cb4a6ead71b2605301dfce31619

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -141 lines) Patch
M webrtc/call/call.cc View 1 2 chunks +22 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 chunks +20 lines, -11 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log2text.cc View 1 2 1 chunk +7 lines, -15 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +20 lines, -22 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 chunk +15 lines, -47 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 1 chunk +9 lines, -13 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
perkj_webrtc
Please?
3 years, 7 months ago (2017-05-03 11:05:33 UTC) #2
the sun
lgtm for voice_engine
3 years, 7 months ago (2017-05-03 13:32:30 UTC) #8
terelius
lgtm
3 years, 7 months ago (2017-05-19 17:09:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2857933002/40001
3 years, 7 months ago (2017-05-22 11:00:24 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 11:08:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/c0876aab46356cb4a6ead71b2...

Powered by Google App Engine
This is Rietveld 408576698