Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc

Issue 2857933002: Replace VideoSendStream::Config with new rtclog::StreamConfig in RtcEventLog. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 252
253 // Check consistency of the parser. 253 // Check consistency of the parser.
254 rtclog::StreamConfig parsed_config; 254 rtclog::StreamConfig parsed_config;
255 parsed_log.GetVideoReceiveConfig(index, &parsed_config); 255 parsed_log.GetVideoReceiveConfig(index, &parsed_config);
256 VerifyStreamConfigsAreEqual(config, parsed_config); 256 VerifyStreamConfigsAreEqual(config, parsed_config);
257 } 257 }
258 258
259 void RtcEventLogTestHelper::VerifyVideoSendStreamConfig( 259 void RtcEventLogTestHelper::VerifyVideoSendStreamConfig(
260 const ParsedRtcEventLog& parsed_log, 260 const ParsedRtcEventLog& parsed_log,
261 size_t index, 261 size_t index,
262 const VideoSendStream::Config& config) { 262 const rtclog::StreamConfig& config) {
263 const rtclog::Event& event = parsed_log.events_[index]; 263 const rtclog::Event& event = parsed_log.events_[index];
264 ASSERT_TRUE(IsValidBasicEvent(event)); 264 ASSERT_TRUE(IsValidBasicEvent(event));
265 ASSERT_EQ(rtclog::Event::VIDEO_SENDER_CONFIG_EVENT, event.type()); 265 ASSERT_EQ(rtclog::Event::VIDEO_SENDER_CONFIG_EVENT, event.type());
266 const rtclog::VideoSendConfig& sender_config = event.video_sender_config(); 266 const rtclog::VideoSendConfig& sender_config = event.video_sender_config();
267 // Check SSRCs. 267
268 ASSERT_EQ(static_cast<int>(config.rtp.ssrcs.size()), 268 EXPECT_EQ(config.local_ssrc, sender_config.ssrcs(0));
269 sender_config.ssrcs_size()); 269 EXPECT_EQ(config.rtx_ssrc, sender_config.rtx_ssrcs(0));
270 for (int i = 0; i < sender_config.ssrcs_size(); i++) { 270
271 EXPECT_EQ(config.rtp.ssrcs[i], sender_config.ssrcs(i));
272 }
273 // Check header extensions. 271 // Check header extensions.
274 ASSERT_EQ(static_cast<int>(config.rtp.extensions.size()), 272 ASSERT_EQ(static_cast<int>(config.rtp_extensions.size()),
275 sender_config.header_extensions_size()); 273 sender_config.header_extensions_size());
276 for (int i = 0; i < sender_config.header_extensions_size(); i++) { 274 for (int i = 0; i < sender_config.header_extensions_size(); i++) {
277 ASSERT_TRUE(sender_config.header_extensions(i).has_name()); 275 ASSERT_TRUE(sender_config.header_extensions(i).has_name());
278 ASSERT_TRUE(sender_config.header_extensions(i).has_id()); 276 ASSERT_TRUE(sender_config.header_extensions(i).has_id());
279 const std::string& name = sender_config.header_extensions(i).name(); 277 const std::string& name = sender_config.header_extensions(i).name();
280 int id = sender_config.header_extensions(i).id(); 278 int id = sender_config.header_extensions(i).id();
281 EXPECT_EQ(config.rtp.extensions[i].id, id); 279 EXPECT_EQ(config.rtp_extensions[i].id, id);
282 EXPECT_EQ(config.rtp.extensions[i].uri, name); 280 EXPECT_EQ(config.rtp_extensions[i].uri, name);
283 }
284 // Check RTX settings.
285 ASSERT_EQ(static_cast<int>(config.rtp.rtx.ssrcs.size()),
286 sender_config.rtx_ssrcs_size());
287 for (int i = 0; i < sender_config.rtx_ssrcs_size(); i++) {
288 EXPECT_EQ(config.rtp.rtx.ssrcs[i], sender_config.rtx_ssrcs(i));
289 }
290 if (sender_config.rtx_ssrcs_size() > 0) {
291 ASSERT_TRUE(sender_config.has_rtx_payload_type());
292 EXPECT_EQ(config.rtp.rtx.payload_type, sender_config.rtx_payload_type());
293 } 281 }
294 // Check encoder. 282 // Check encoder.
295 ASSERT_TRUE(sender_config.has_encoder()); 283 ASSERT_TRUE(sender_config.has_encoder());
296 ASSERT_TRUE(sender_config.encoder().has_name()); 284 ASSERT_TRUE(sender_config.encoder().has_name());
297 ASSERT_TRUE(sender_config.encoder().has_payload_type()); 285 ASSERT_TRUE(sender_config.encoder().has_payload_type());
298 EXPECT_EQ(config.encoder_settings.payload_name, 286 EXPECT_EQ(config.codecs[0].payload_name, sender_config.encoder().name());
299 sender_config.encoder().name()); 287 EXPECT_EQ(config.codecs[0].payload_type,
300 EXPECT_EQ(config.encoder_settings.payload_type,
301 sender_config.encoder().payload_type()); 288 sender_config.encoder().payload_type());
302 289
290 EXPECT_EQ(config.codecs[0].rtx_payload_type,
291 sender_config.rtx_payload_type());
292
303 // Check consistency of the parser. 293 // Check consistency of the parser.
304 VideoSendStream::Config parsed_config(nullptr); 294 rtclog::StreamConfig parsed_config;
305 parsed_log.GetVideoSendConfig(index, &parsed_config); 295 parsed_log.GetVideoSendConfig(index, &parsed_config);
306 // Check SSRCs 296 VerifyStreamConfigsAreEqual(config, parsed_config);
307 EXPECT_EQ(config.rtp.ssrcs.size(), parsed_config.rtp.ssrcs.size());
308 for (size_t i = 0; i < config.rtp.ssrcs.size(); i++) {
309 EXPECT_EQ(config.rtp.ssrcs[i], parsed_config.rtp.ssrcs[i]);
310 }
311 // Check header extensions.
312 EXPECT_EQ(config.rtp.extensions.size(), parsed_config.rtp.extensions.size());
313 for (size_t i = 0; i < parsed_config.rtp.extensions.size(); i++) {
314 EXPECT_EQ(config.rtp.extensions[i].uri,
315 parsed_config.rtp.extensions[i].uri);
316 EXPECT_EQ(config.rtp.extensions[i].id, parsed_config.rtp.extensions[i].id);
317 }
318 // Check RTX settings.
319 EXPECT_EQ(config.rtp.rtx.ssrcs.size(), parsed_config.rtp.rtx.ssrcs.size());
320 for (size_t i = 0; i < config.rtp.rtx.ssrcs.size(); i++) {
321 EXPECT_EQ(config.rtp.rtx.ssrcs[i], parsed_config.rtp.rtx.ssrcs[i]);
322 }
323 EXPECT_EQ(config.rtp.rtx.payload_type, parsed_config.rtp.rtx.payload_type);
324 // Check encoder.
325 EXPECT_EQ(config.encoder_settings.payload_name,
326 parsed_config.encoder_settings.payload_name);
327 EXPECT_EQ(config.encoder_settings.payload_type,
328 parsed_config.encoder_settings.payload_type);
329 } 297 }
330 298
331 void RtcEventLogTestHelper::VerifyAudioReceiveStreamConfig( 299 void RtcEventLogTestHelper::VerifyAudioReceiveStreamConfig(
332 const ParsedRtcEventLog& parsed_log, 300 const ParsedRtcEventLog& parsed_log,
333 size_t index, 301 size_t index,
334 const AudioReceiveStream::Config& config) { 302 const AudioReceiveStream::Config& config) {
335 const rtclog::Event& event = parsed_log.events_[index]; 303 const rtclog::Event& event = parsed_log.events_[index];
336 ASSERT_TRUE(IsValidBasicEvent(event)); 304 ASSERT_TRUE(IsValidBasicEvent(event));
337 ASSERT_EQ(rtclog::Event::AUDIO_RECEIVER_CONFIG_EVENT, event.type()); 305 ASSERT_EQ(rtclog::Event::AUDIO_RECEIVER_CONFIG_EVENT, event.type());
338 const rtclog::AudioReceiveConfig& receiver_config = 306 const rtclog::AudioReceiveConfig& receiver_config =
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 ASSERT_TRUE(bwe_event.has_id()); 598 ASSERT_TRUE(bwe_event.has_id());
631 EXPECT_EQ(id, bwe_event.id()); 599 EXPECT_EQ(id, bwe_event.id());
632 ASSERT_TRUE(bwe_event.has_result()); 600 ASSERT_TRUE(bwe_event.has_result());
633 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result()); 601 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result());
634 ASSERT_FALSE(bwe_event.has_bitrate_bps()); 602 ASSERT_FALSE(bwe_event.has_bitrate_bps());
635 603
636 // TODO(philipel): Verify the parser when parsing has been implemented. 604 // TODO(philipel): Verify the parser when parsing has been implemented.
637 } 605 }
638 606
639 } // namespace webrtc 607 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h ('k') | webrtc/tools/event_log_visualizer/analyzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698