Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: webrtc/call/call.cc

Issue 2857933002: Replace VideoSendStream::Config with new rtclog::StreamConfig in RtcEventLog. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index f9f1fb5eab5c0abebeb3c79809cafda92acc7f63..0297867a6fd4a713b070960da7dc55e1d22fed07 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -107,6 +107,23 @@ rtclog::StreamConfig CreateRtcLogStreamConfig(
return rtclog_config;
}
+rtclog::StreamConfig CreateRtcLogStreamConfig(
+ const VideoSendStream::Config& config,
+ size_t ssrc_index) {
+ rtclog::StreamConfig rtclog_config;
+ rtclog_config.local_ssrc = config.rtp.ssrcs[ssrc_index];
+ if (ssrc_index < config.rtp.rtx.ssrcs.size()) {
+ rtclog_config.rtx_ssrc = config.rtp.rtx.ssrcs[ssrc_index];
+ }
+ rtclog_config.rtcp_mode = config.rtp.rtcp_mode;
+ rtclog_config.rtp_extensions = config.rtp.extensions;
+
+ rtclog_config.codecs.emplace_back(config.encoder_settings.payload_name,
+ config.encoder_settings.payload_type,
+ config.rtp.rtx.payload_type);
+ return rtclog_config;
+}
+
} // namespace
namespace internal {
@@ -638,7 +655,11 @@ webrtc::VideoSendStream* Call::CreateVideoSendStream(
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
video_send_delay_stats_->AddSsrcs(config);
- event_log_->LogVideoSendStreamConfig(config);
+ for (size_t ssrc_index = 0; ssrc_index < config.rtp.ssrcs.size();
+ ++ssrc_index) {
+ event_log_->LogVideoSendStreamConfig(
+ CreateRtcLogStreamConfig(config, ssrc_index));
+ }
// TODO(mflodman): Base the start bitrate on a current bandwidth estimate, if
// the call has already started.
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698